Avoid NPE on repositories and other GitBlit screens.
Returns empty lists instead of nulls in order to
prevent NPE in various points of GitBlit screens.
(including the list of repositories, previously broken)
Change-Id: I13d42dd3b8bc4eed83cb7ddc98be03e944eca95e
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitblit/auth/GerritToGitBlitUserService.java b/src/main/java/com/googlesource/gerrit/plugins/gitblit/auth/GerritToGitBlitUserService.java
index 46504a6..7ba6182 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitblit/auth/GerritToGitBlitUserService.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitblit/auth/GerritToGitBlitUserService.java
@@ -14,6 +14,7 @@
package com.googlesource.gerrit.plugins.gitblit.auth;
import java.util.Collection;
+import java.util.Collections;
import java.util.List;
import org.slf4j.Logger;
@@ -185,27 +186,27 @@
@Override
public List<String> getAllUsernames() {
- return null;
+ return Collections.emptyList();
}
@Override
public List<UserModel> getAllUsers() {
- return null;
+ return Collections.emptyList();
}
@Override
public List<String> getAllTeamNames() {
- return null;
+ return Collections.emptyList();
}
@Override
public List<TeamModel> getAllTeams() {
- return null;
+ return Collections.emptyList();
}
@Override
public List<String> getTeamnamesForRepositoryRole(String role) {
- return null;
+ return Collections.emptyList();
}
@Override
@@ -241,7 +242,7 @@
@Override
public List<String> getUsernamesForRepositoryRole(String role) {
- return null;
+ return Collections.emptyList();
}
@Override
