Fix errorprone [FloggerLogString] errors
To fix this use Flogger's formatting log methods.
Change-Id: I6a67bee47218201ccf14a0cb4bbc2fb354cefea2
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCache.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCache.java
index ad71e7f..2a509cb 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCache.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCache.java
@@ -90,8 +90,7 @@
(repoMetric, value) -> {
String metricsName = getMetricName(repoMetric.getName(), projectName);
logger.atFine().log(
- String.format(
- "Collected %s for project %s: %d", repoMetric.getName(), projectName, value));
+ "Collected %s for project %s: %d", repoMetric.getName(), projectName, value);
metrics.put(metricsName, value);
if (!metricExists(metricsName)) {
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoUpdateListener.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoUpdateListener.java
index 3ac4903..a13f3a6 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoUpdateListener.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoUpdateListener.java
@@ -48,9 +48,8 @@
if (event instanceof RefUpdatedEvent || isReplicationDoneEvent(event)) {
String projectName = ((ProjectEvent) event).getProjectNameKey().get();
logger.atFine().log(
- String.format(
- "Got %s event from %s. Might need to collect metrics for project %s",
- event.type, event.instanceId, projectName));
+ "Got %s event from %s. Might need to collect metrics for project %s",
+ event.type, event.instanceId, projectName);
if (gitRepoMetricsCache.shouldCollectStats(projectName)) {
UpdateGitMetricsTask updateGitMetricsTask = updateGitMetricsTaskFactory.create(projectName);
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
index 191a5e7..838429e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
@@ -69,9 +69,8 @@
metrics.forEach(
(repoMetric, value) -> {
logger.atFine().log(
- String.format(
- "Collected %s for project %s: %d",
- repoMetric.getName(), projectName, value));
+ "Collected %s for project %s: %d",
+ repoMetric.getName(), projectName, value);
newMetrics.put(repoMetric, value);
});
gitRepoMetricsCache.setMetrics(newMetrics, projectName);
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/FSMetricsCollector.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/FSMetricsCollector.java
index d9f352f..f37c293 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/FSMetricsCollector.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/FSMetricsCollector.java
@@ -135,7 +135,7 @@
return metricsRecord.toMap();
} catch (IOException e) {
logger.atSevere().withCause(e).log(
- "Error reading from file system for project " + projectName);
+ "Error reading from file system for project %s", projectName);
}
return new MetricsRecord().toMap();
