commit b984e8d78a8dcf6831d908cb881b633519d37319
author Fabio Ponciroli <ponch78@gmail.com> Fri Jun 03 17:23:09 2022 +0200
committer Fabio Ponciroli <ponch78@gmail.com> Mon Jun 06 20:04:54 2022 +0000
tree 7fc42812360d2b3e876b0d42e37bbc775022c0f3
parent a2c3f297295360647673761605bebfd5f7033e7c

No need to use a lambda when populating stats

The function to collect the statistic is called synchronously anyway.
No need to have it, we can pass the value directly.

Change-Id: I4d07d8bc57db59855f5b7cb8cf31ecacb0c12254

src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStats.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStats.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStats.java
index 8b8c2d7..059fa47 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStats.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStats.java
@@ -22,7 +22,6 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
-import java.util.function.Function;
 import org.eclipse.jgit.internal.storage.file.FileRepository;
 import org.eclipse.jgit.internal.storage.file.GC;
 
@@ -52,14 +51,14 @@
     Map<String, Long> metrics = new java.util.HashMap<>(Collections.emptyMap());
     try {
       GC.RepoStatistics statistics = new GC(repository).getStatistics();
-      putMetric(metrics, numberOfPackedObjects, s -> s.numberOfPackedObjects, statistics);
-      putMetric(metrics, numberOfPackFiles, s -> s.numberOfPackFiles, statistics);
-      putMetric(metrics, numberOfLooseObjects, s -> s.numberOfLooseObjects, statistics);
-      putMetric(metrics, numberOfLooseRefs, s -> s.numberOfLooseRefs, statistics);
-      putMetric(metrics, numberOfPackedRefs, s -> s.numberOfPackedRefs, statistics);
-      putMetric(metrics, sizeOfLooseObjects, s -> s.sizeOfLooseObjects, statistics);
-      putMetric(metrics, sizeOfPackedObjects, s -> s.sizeOfPackedObjects, statistics);
-      putMetric(metrics, numberOfBitmaps, s -> s.numberOfBitmaps, statistics);
+      putMetric(metrics, numberOfPackedObjects, statistics.numberOfPackedObjects);
+      putMetric(metrics, numberOfPackFiles, statistics.numberOfPackFiles);
+      putMetric(metrics, numberOfLooseObjects, statistics.numberOfLooseObjects);
+      putMetric(metrics, numberOfLooseRefs, statistics.numberOfLooseRefs);
+      putMetric(metrics, numberOfPackedRefs, statistics.numberOfPackedRefs);
+      putMetric(metrics, sizeOfLooseObjects, statistics.sizeOfLooseObjects);
+      putMetric(metrics, sizeOfPackedObjects, statistics.sizeOfPackedObjects);
+      putMetric(metrics, numberOfBitmaps, statistics.numberOfBitmaps);
       logger.atInfo().log("New Git Statistics metrics collected: %s", statistics.toString());
     } catch (IOException e) {
       logger.atSevere().log("Something went wrong: %s", e.getMessage());
@@ -82,8 +81,7 @@
   private void putMetric(
       Map<String, Long> metrics,
       String metricName,
-      Function<GC.RepoStatistics, Long> fn,
-      GC.RepoStatistics statistics) {
-    metrics.put(GitRepoMetricsCache.getMetricName(metricName, p.getName()), fn.apply(statistics));
+      long value) {
+    metrics.put(GitRepoMetricsCache.getMetricName(metricName, p.getName()), value);
   }
 }