commit 4ecc81dd29e3b314c9687c9cbffe9491aba1d6d8
author Fabio Ponciroli <ponch78@gmail.com> Fri Aug 26 17:19:19 2022 +0200
committer Fabio Ponciroli <ponch78@gmail.com> Tue Sep 13 07:42:57 2022 +0000
tree 8f7445b45aa428e7097731f1be3ce3d2b6ce3d05
parent 2ccb5b3b13434d857d69fce1646007dfc9bede8e

Remove not needed parameterless constructor

No need to have parameter/body-less constructor,
since it will only add boilerplate code to maintain.

Furthermore, use injection to avoid changes in tests in
the future, as long as the constructors will
have injectable parameters.

Change-Id: Ie6b6672b4362ed33f144ac80506c3a041fee5a36

src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStatsMetricsCollector.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStatsMetricsCollector.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStatsMetricsCollector.java
index aa01d1a..bb9d9cd 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStatsMetricsCollector.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/collectors/GitStatsMetricsCollector.java
@@ -33,8 +33,6 @@
   public static String sizeOfPackedObjects = "sizeOfPackedObjects";
   public static String numberOfBitmaps = "numberOfBitmaps";
 
-  public GitStatsMetricsCollector() {}
-
   @Override
   public HashMap<String, Long> collect(FileRepository repository, String projectName) {
     HashMap<String, Long> metrics = new HashMap<>(availableMetrics().size());

src/test/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCacheIT.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCacheIT.java b/src/test/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCacheIT.java
index f9693ac..8882edd 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCacheIT.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/gitrepometrics/GitRepoMetricsCacheIT.java
@@ -35,6 +35,8 @@
 public class GitRepoMetricsCacheIT extends LightweightPluginDaemonTest {
 
   @Inject MetricRegistry metricRegistry;
+  @Inject FSMetricsCollector fsMetricsCollector;
+  @Inject GitStatsMetricsCollector gitStatsMetricsCollector;
 
   @Test
   @UseLocalDisk
@@ -50,9 +52,8 @@
             .collect(Collectors.toList());
 
     int expectedMetricsCount =
-        new GitStatsMetricsCollector().availableMetrics().size()
-            + new FSMetricsCollector().availableMetrics().size();
-
+        gitStatsMetricsCollector.availableMetrics().size()
+            + fsMetricsCollector.availableMetrics().size();
     assertThat(repoMetricsCount.size()).isEqualTo(availableProjects.size() * expectedMetricsCount);
   }
 }