commit f7aac08cafafc8bdea78edf935c27ca6851dc40a
author David Pursehouse <dpursehouse@collab.net> Tue Aug 30 21:38:25 2016 +0900
committer David Pursehouse <dpursehouse@collab.net> Tue Aug 30 23:46:50 2016 +0900
tree 4028379aa488edf3dd20c1cd7a96e5f15aecf60c
parent 8915cba97a93f4187608f4ec506a78f21cad07e5

Replace switch statement with if-else block

Eclipse warns about missing case statements for the Change.Status enum,
but since we only need to check NEW it makes more sense to replace the
switch with an if-else than to add empty cases for the other values.

Change-Id: Ia76057da37adca1309c5180082b968bac7d92605

src/main/java/com/googlesource/gerrit/plugins/forcedraft/ForceDraft.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/forcedraft/ForceDraft.java b/src/main/java/com/googlesource/gerrit/plugins/forcedraft/ForceDraft.java
index 88ac0d4..fe8991c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/forcedraft/ForceDraft.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/forcedraft/ForceDraft.java
@@ -217,15 +217,12 @@
    */
   private void updatePatchSet() throws OrmException {
     Change.Status changeStatus = parentChange.getStatus();
-    switch (changeStatus) {
-      case NEW:
-        setPatchSetAsDraft();
-        updateChange();
-        break;
-      default:
-        sendUserInfo("Unable to set patch set as draft, change is "
-            + getStatusName(changeStatus));
-        break;
+    if (changeStatus == Change.Status.NEW) {
+      setPatchSetAsDraft();
+      updateChange();
+    } else {
+      sendUserInfo("Unable to set patch set as draft, change is "
+          + getStatusName(changeStatus));
     }
   }