Improve logged message and Java coding style
* Fix error in wrong OWNERS_FILE_NAME log message.
* Add projectName to missing root owners file message.
Change-Id: I511343f9706540a330a215f3e4feb4b2f4c2b0b4
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
index 537df74..20b5d11 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
@@ -101,12 +101,8 @@
.getFromProjectConfigWithInheritance(projectState, PLUGIN_NAME)
.getString(OWNERS_FILE_NAME, OWNERS);
if (name.trim().equals("")) {
- logger.atSevere().log(
- "Project %s has wrong %s: \"%s\" for %s"
- + projectState.getProject()
- + OWNERS_FILE_NAME
- + name
- + getChangeId(c));
+ logger.atSevere().log("Project %s has wrong %s: \"%s\" for %s",
+ projectState.getProject(), OWNERS_FILE_NAME, name, getChangeId(c));
return OWNERS;
}
return name;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
index 59887c9..23cc28a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
@@ -107,7 +107,8 @@
String found = "Found";
if (content.isEmpty()) {
String changeId = Config.getChangeId(changeData);
- logger.atSevere().log("Missing root %s for %s", ownersFileName, changeId);
+ logger.atSevere().log("Missing root %s for %s of %s",
+ ownersFileName, changeId, projectName);
found = "Missing";
}
logs.add(found + " root " + ownersFileName);