Use Google Java coding style.
Change-Id: I5fd1efc2613d9142269652cbc2d69d08bd554f97
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/Parser.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/Parser.java
index 1264e78..690e474 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/Parser.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/Parser.java
@@ -156,8 +156,8 @@
} else if ((email = parseEmail(line)) != null) {
Util.addToMap(result.owner2paths, email, dir);
} else if ((globsAndEmails = parsePerFile(line)) != null) {
- String[] emails = globsAndEmails[1].split(COMMA);
- for (String glob : globsAndEmails[0].split(COMMA)) {
+ String[] emails = globsAndEmails[1].split(COMMA, -1);
+ for (String glob : globsAndEmails[0].split(COMMA, -1)) {
for (String e : emails) {
Util.addToMap(result.owner2paths, e, dir + glob);
}
diff --git a/src/test/java/com/googlesource/gerrit/plugins/findowners/ParserTest.java b/src/test/java/com/googlesource/gerrit/plugins/findowners/ParserTest.java
index bd50f0a..2f50420 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/findowners/ParserTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/findowners/ParserTest.java
@@ -125,11 +125,11 @@
"a@g.com , xyz@gmail.com , * # comment", "*,*#comment", " a@b,c@d "
};
String[] globsList = {"*", "*,*.c", " *test*.java , *.cc, *.cpp ", "*.bp,*.mk ,A* "};
- for (int i = 0; i < directives.length; i++) {
+ for (String directive : directives) {
for (String globs : globsList) {
- String line = "per-file " + globs + "=" + directives[i];
+ String line = "per-file " + globs + "=" + directive;
Parser.Result result = testLine(line);
- String[] emailList = directives[i].replaceAll("#.*$", "").trim().split(Parser.COMMA);
+ String[] emailList = directive.replaceAll("#.*$", "").trim().split(Parser.COMMA, -1);
String[] globList = globs.trim().split(Parser.COMMA);
Arrays.sort(globList);
for (String email : emailList) {
@@ -150,8 +150,8 @@
"file://OWNERS", " ** ", "a b@c .co", "a@b@c #com", "a.<b>@zc#", " set noparent ",
" , a@b ", "a@b, , c@d #"
};
- for (int i = 0; i < directives.length; i++) {
- String line = "per-file *test*.c=" + directives[i];
+ for (String directive : directives) {
+ String line = "per-file *test*.c=" + directive;
Parser.Result result = testLine(line);
String expected = testLineErrorMsg(line);
assertThat(result.warnings).isEmpty();
