commit 4f307d0c09308f611d5dec832acd49811c1809b6
author Chih-hung Hsieh <chh@google.com> Thu Jan 31 23:55:20 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Jan 31 23:55:20 2019 +0000
tree 35846c10d41e6d7abdbc43723cce409ec44ca550
parent 43cdab47af14a1f95309abc0c9cccc1dc87d8588
parent f38e94d7bd437e115e5606cc00bd69e3387c3446

Merge "Improve logged message and Java coding style"

src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
index 537df74..20b5d11 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
@@ -101,12 +101,8 @@
               .getFromProjectConfigWithInheritance(projectState, PLUGIN_NAME)
               .getString(OWNERS_FILE_NAME, OWNERS);
       if (name.trim().equals("")) {
-        logger.atSevere().log(
-            "Project %s has wrong %s: \"%s\" for %s"
-                + projectState.getProject()
-                + OWNERS_FILE_NAME
-                + name
-                + getChangeId(c));
+        logger.atSevere().log("Project %s has wrong %s: \"%s\" for %s",
+            projectState.getProject(), OWNERS_FILE_NAME, name, getChangeId(c));
         return OWNERS;
       }
       return name;

src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
index 59887c9..23cc28a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersDb.java
@@ -107,7 +107,8 @@
           String found = "Found";
           if (content.isEmpty()) {
             String changeId = Config.getChangeId(changeData);
-            logger.atSevere().log("Missing root %s for %s", ownersFileName, changeId);
+            logger.atSevere().log("Missing root %s for %s of %s",
+                ownersFileName, changeId, projectName);
             found = "Missing";
           }
           logs.add(found + " root " + ownersFileName);