Use only "Code-Review" votes. * An owner can vote on multiple labels. Only the "Code-Review" vote should be used for owner-approval check. Change-Id: I52d6d1a7743f7ec42f244ce7512cbbf80b763fa8
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/Checker.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/Checker.java index 54861a1..30d1a4c 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/findowners/Checker.java +++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/Checker.java
@@ -55,7 +55,8 @@ throws OrmException { Map<String, Integer> map = new HashMap<>(); for (PatchSetApproval p : changeData.currentApprovals()) { - if (p.getValue() != 0) { + // Only collect non-zero Code-Review votes. + if (p.getValue() != 0 && p.getLabel().equals("Code-Review")) { // Reviewers may have no preferred email, skip them if the preferred email is not set. Optional<String> preferredEmail = accountCache.get(p.getAccountId()).map(a -> a.getAccount().getPreferredEmail());