Make EiffelEventParsingQueue#scheduleArtcCreation private scheduleArtcCreation(String,String,Long,boolean) is only used from within the class. Solves: Jira GER-1715 Change-Id: I389968ed2457c3b826ae32bdd5dd4e6ffce8bd24
diff --git a/src/main/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParsingQueue.java b/src/main/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParsingQueue.java index 8f1f424..a5f1846 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParsingQueue.java +++ b/src/main/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParsingQueue.java
@@ -148,30 +148,6 @@ resource.getName(), tagRef, resource.getTagInfo().created.getTime(), force); } - public void scheduleArtcCreation( - String projectName, String tagRefOrName, Long creationTime, boolean force) { - String tagName = - tagRefOrName.startsWith(RefNames.REFS_TAGS) - ? tagRefOrName.substring(RefNames.REFS_TAGS.length()) - : tagRefOrName; - schedule( - new EventParsingWorker( - ParsingQueueTask.builder(ARTC, projectName, tagName) - .updateTime(creationTime) - .force(force)) { - - @Override - public void doRun() { - try { - eventParser.createAndScheduleArtc(projectName, tagName, creationTime, force); - } catch (Exception e) { - logger.atSevere().withCause(e).log( - "Failed to create ARTC for %s:%s", projectName, tagName); - } - } - }); - } - public void shutDown() { for (ScheduledFuture<?> f : pending.values()) { f.cancel(true); @@ -214,6 +190,30 @@ }); } + private void scheduleArtcCreation( + String projectName, String tagRefOrName, Long creationTime, boolean force) { + String tagName = + tagRefOrName.startsWith(RefNames.REFS_TAGS) + ? tagRefOrName.substring(RefNames.REFS_TAGS.length()) + : tagRefOrName; + schedule( + new EventParsingWorker( + ParsingQueueTask.builder(ARTC, projectName, tagName) + .updateTime(creationTime) + .force(force)) { + + @Override + public void doRun() { + try { + eventParser.createAndScheduleArtc(projectName, tagName, creationTime, force); + } catch (Exception e) { + logger.atSevere().withCause(e).log( + "Failed to create ARTC for %s:%s", projectName, tagName); + } + } + }); + } + private void schedule(EventParsingWorker worker) { ScheduledFuture<?> future = pool.schedule(worker); if (future != null) {