Fix EiffelEventParserIt#artcQueued The intention was to test that no ArtC was created when the SCS for the commit didn't exist already. But ArtC creation failed because CD/ArtC cannot be created for a tag that doesn't exist regardless of whether the corresponding SCS is created or not. Also rename the test to reflect what it's testing. Solves: Jira GER-1733 Change-Id: I4e25b3eb67d2bd895457277a2a3a39e3b45edf2f
diff --git a/src/test/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParserIT.java b/src/test/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParserIT.java index 509beba..77693b7 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParserIT.java +++ b/src/test/java/com/googlesource/gerrit/plugins/eventseiffel/parsing/EiffelEventParserIT.java
@@ -223,8 +223,10 @@ } @Test - public void artcQueued() throws Exception { - eventParser.createAndScheduleArtc(project.get(), TAG_NAME, EPOCH_MILLIS, false); + public void artcNotCreatedWhenMissingScs() throws Exception { + String tag = + createTagRef(getHead(repo(), "HEAD").getName(), true).substring(Constants.R_TAGS.length()); + eventParser.createAndScheduleArtc(project.get(), tag, EPOCH_MILLIS, false); assertEquals(0, TestEventHub.EVENTS.size()); }