commit e345e6e79900a72981e4ad19d37c7fbdcae4818b
author David Ostrovsky <david@ostrovsky.org> Thu May 21 14:56:00 2020 +0200
committer David Pursehouse <dpursehouse@digital.ai> Thu May 21 14:30:55 2020 +0000
tree 2f3d5393e9f32148e868dcc6085dc95127d6b066
parent ea75463210b821d0b41c4a15a902c600bdf50285

Fix ProtectedMembersInFinalClass error flagged by error prone

Running recent error prone version complaining on that code:

DeleteCommand.java:53: error: [ProtectedMembersInFinalClass] Make members
of final classes package-private: <init>
  protected DeleteCommand(DeleteProject deleteProject, DeletePreconditions preConditions) {
            ^
    (see https://errorprone.info/bugpattern/ProtectedMembersInFinalClass)

Bug: Issue 12677
Change-Id: I3ef90ac3106240403dc88178262edf2447f30cb8

src/main/java/com/googlesource/gerrit/plugins/deleteproject/DeleteCommand.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/deleteproject/DeleteCommand.java b/src/main/java/com/googlesource/gerrit/plugins/deleteproject/DeleteCommand.java
index e5df5a3..a444859 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/deleteproject/DeleteCommand.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/deleteproject/DeleteCommand.java
@@ -25,7 +25,7 @@
 import org.kohsuke.args4j.Option;
 
 @CommandMetaData(name = "delete", description = "Delete specific project")
-public final class DeleteCommand extends SshCommand {
+final class DeleteCommand extends SshCommand {
   private static final String FORCE_DELETE =
       "%s - To really delete '%s', re-run with the --force flag.";
   private static final String REALLY_DELETE =
@@ -50,7 +50,7 @@
   private final DeletePreconditions preConditions;
 
   @Inject
-  protected DeleteCommand(DeleteProject deleteProject, DeletePreconditions preConditions) {
+  DeleteCommand(DeleteProject deleteProject, DeletePreconditions preConditions) {
     this.deleteProject = deleteProject;
     this.preConditions = preConditions;
   }