Remove final qualifiers Final qualifier in private methods are redundant as per JLS: "A private method and all methods declared immediately within a final class (ยง8.1.1.2) behave as if they are final, since it is impossible to override them." Also remove final qualifier from method parameters according to Gerrit code style guide [1]. [1] https://gerrit-review.googlesource.com/Documentation/dev-contributing.html#style Change-Id: Ibe60561118f78b9bc413e5a3fd0a933799473195
diff --git a/src/main/java/com/googlesource/gerrit/plugins/deleteproject/database/DatabaseDeleteHandler.java b/src/main/java/com/googlesource/gerrit/plugins/deleteproject/database/DatabaseDeleteHandler.java index 5e0a2f8..9585cff 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/deleteproject/database/DatabaseDeleteHandler.java +++ b/src/main/java/com/googlesource/gerrit/plugins/deleteproject/database/DatabaseDeleteHandler.java
@@ -150,7 +150,7 @@ } } - private final void deleteChanges(ReviewDb db, Project.NameKey project, List<Change.Id> changeIds) + private void deleteChanges(ReviewDb db, Project.NameKey project, List<Change.Id> changeIds) throws OrmException { for (Change.Id id : changeIds) { @@ -180,8 +180,7 @@ } } - private final void deleteFromPatchSets(ReviewDb db, final ResultSet<PatchSet> patchSets) - throws OrmException { + private void deleteFromPatchSets(ReviewDb db, ResultSet<PatchSet> patchSets) throws OrmException { for (PatchSet patchSet : patchSets) { accountPatchReviewStore.get().clearReviewed(patchSet.getId()); db.patchSets().delete(Collections.singleton(patchSet));