Buck: Don't depend transitively on dropwizard library
Dropwizard library is shipped in gerrit core and thus included in
gerrit.war. Because gerrit-server transitively depends on it, it
is also included in plugin API. It's always wrong to include library
in plugin.jar binary artifact that already included in gerrit.war.
There is possibility of versions collision, when different library
versions included in gerrit.war and plugin.jar, not to mention that
this unnesessary increases binary plugin artifact size.
Probably this dependency was added, to allow plugin to use dropwizard
library in tree build. The correct way to achieve this is to export
the library, as was done in: Idcda84cd.
This change partialy reverts I4a694cf5 and Ifa93527d.
Change-Id: I35f9762ca2ae4adedc9237eff70c69fa1e64c53b
diff --git a/BUCK b/BUCK
index 7aa2580..0160c15 100644
--- a/BUCK
+++ b/BUCK
@@ -15,9 +15,6 @@
'Implementation-Title: Cookbook plugin',
'Implementation-URL: https://gerrit-review.googlesource.com/#/admin/projects/plugins/cookbook-plugin',
],
- deps = [
- '//lib/dropwizard:dropwizard-core'
- ],
)
java_test(
diff --git a/lib/dropwizard/BUCK b/lib/dropwizard/BUCK
deleted file mode 100644
index d009eee..0000000
--- a/lib/dropwizard/BUCK
+++ /dev/null
@@ -1,8 +0,0 @@
-include_defs('//bucklets/maven_jar.bucklet')
-
-maven_jar(
- name = 'dropwizard-core',
- id = 'io.dropwizard.metrics:metrics-core:3.1.2',
- sha1 = '224f03afd2521c6c94632f566beb1bb5ee32cf07',
- license = 'Apache2.0',
-)
