commit ecec6dfe7ed67431d96acf9dabac3885463900e8
author David Pursehouse <david.pursehouse@sonymobile.com> Tue Mar 17 09:56:23 2015 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Tue Mar 17 09:56:23 2015 +0900
tree 1e934af6de6a400d4ce3e621814f1aed2a1d7a73
parent cee1dcd7bdfaa82e2e72ebc382ec13c393892125

Fix Checkstyle warnings

- Fix placement of { on class declaration
- Update ordering of modifiers according to JLS spec
- Don't declare multiple variables on a single line

Change-Id: If8b036e73f37fa1786382bd3fbcc7e303cd5f13d

src/main/java/com/googlesource/gerrit/plugins/validators/CommitMessageLengthValidation.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/validators/CommitMessageLengthValidation.java b/src/main/java/com/googlesource/gerrit/plugins/validators/CommitMessageLengthValidation.java
index 96dd89e..9e3876e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/validators/CommitMessageLengthValidation.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/validators/CommitMessageLengthValidation.java
@@ -32,15 +32,15 @@
 @Listen
 @Singleton
 public class CommitMessageLengthValidation implements CommitValidationListener {
-  private final static int DEFAULT_MAX_SUBJECT_LENGTH = 65;
-  private final static int DEFAULT_MAX_LINE_LENGTH = 70;
-  private final static int DEFAULT_LONG_LINES_THRESHOLD = 33;
-  private final static boolean DEFAULT_REJECT_TOO_LONG = false;
-  private final static String COMMIT_MESSAGE_SECTION = "commitmessage";
-  private final static String MAX_SUBJECT_LENGTH_KEY = "maxSubjectLength";
-  private final static String MAX_LINE_LENGTH_KEY = "maxLineLength";
-  private final static String REJECT_TOO_LONG_KEY = "rejectTooLong";
-  private final static String LONG_LINES_THRESHOLD_KEY = "longLinesThreshold";
+  private static final int DEFAULT_MAX_SUBJECT_LENGTH = 65;
+  private static final int DEFAULT_MAX_LINE_LENGTH = 70;
+  private static final int DEFAULT_LONG_LINES_THRESHOLD = 33;
+  private static final boolean DEFAULT_REJECT_TOO_LONG = false;
+  private static final String COMMIT_MESSAGE_SECTION = "commitmessage";
+  private static final String MAX_SUBJECT_LENGTH_KEY = "maxSubjectLength";
+  private static final String MAX_LINE_LENGTH_KEY = "maxLineLength";
+  private static final String REJECT_TOO_LONG_KEY = "rejectTooLong";
+  private static final String LONG_LINES_THRESHOLD_KEY = "longLinesThreshold";
 
   private final Config config;
   private final int maxSubjectLength;
@@ -49,8 +49,7 @@
   private boolean rejectTooLong;
 
   @Inject
-  public CommitMessageLengthValidation(@GerritServerConfig Config gerritConfig)
-      {
+  public CommitMessageLengthValidation(@GerritServerConfig Config gerritConfig) {
     this.config = gerritConfig;
     this.maxSubjectLength = nonNegativeInt(
         MAX_SUBJECT_LENGTH_KEY, DEFAULT_MAX_SUBJECT_LENGTH);
@@ -92,7 +91,8 @@
               + " characters; use shorter first paragraph"));
     }
 
-    int longLineCnt = 0, nonEmptyCnt = 0;
+    int longLineCnt = 0;
+    int nonEmptyCnt = 0;
     for (String line : commit.getFullMessage().split("\n")) {
       if (!line.trim().isEmpty()) {
         nonEmptyCnt++;