commit cddb6d80cdd11fafb319707899dd5928ca9d4002
author Milutin Kristofic <milutin@google.com> Wed Aug 21 12:15:22 2024 +0200
committer Milutin Kristofic <milutin@google.com> Wed Aug 21 10:27:33 2024 +0000
tree 5bfe54a94c9f3aedfbfa99ff7a2088c2f1932b47
parent d4f9247d3efb6a0e461af701986235511d05b7e3

Show Line Length Indicator at 72 Characters for Commit Messages

This is recommended line length for commit messages.

Screenshot: https://imgur.com/a/Mi8dOLR

Google-Bug-Id: b/361035569
Release-Notes: skip
Change-Id: Iadaac002ad7be33f69bac2fe5e051ff501e964bf

web/element/codemirror-element.ts

diff --git a/web/element/codemirror-element.ts b/web/element/codemirror-element.ts
index 98dd811..206d7fd 100644
--- a/web/element/codemirror-element.ts
+++ b/web/element/codemirror-element.ts
@@ -113,13 +113,17 @@
             this.darkMode
           ),
           EditorView.updateListener.of(update => {
-            if (this.prefs?.line_length) {
+            // Set ruler width to 72 for commit messages,
+            // as this is the recommended line length for git commit messages.
+            if (this.fileType?.includes('x-gerrit-commit-message')) {
+              updateRulerWidth(72, update.view.defaultCharacterWidth, true);
+            } else if (this.prefs?.line_length) {
               // This is required to be in the setTimeout() to ensure the
               // line is set as correctly as possible.
               updateRulerWidth(
-                  this.prefs.line_length,
-                  update.view.defaultCharacterWidth,
-                  true
+                this.prefs.line_length,
+                update.view.defaultCharacterWidth,
+                true
               );
             }