Google Git
Sign in
gerrit / plugins / codemirror-editor

CodeMirror plugin for PolyGerrit

Clone this repo:

Branches

Tags

More...
  1. e0a6721 Remove need for hack by Paladox none · 23 hours ago master
  2. 42d5fe0 Bazel: Migrate from bower to npm by David Ostrovsky · 8 weeks ago
  3. 7c94eb2 Bazel: Don't use assets parameter in polygerrit_plugin rule by David Ostrovsky · 9 weeks ago v3.4.0 v3.4.0-rc3 v3.4.0-rc4 v3.4.0-rc5
  4. 30c774f Switch over to loading .js file by Paladox none · 3 months ago v3.4.0-rc1 v3.4.0-rc2
  5. 3cd520b Set rel and href as attributes by Ben Rohlfs · 4 months ago v3.4.0-rc0

CodeMirror Editor

A plugin that uses CodeMirror to provide a rich code editing experience in PolyGerrit.

UI plugin

This plugin is rewritten into Polymer 3 syntax. The gr-editor.js is the main entry for the plugin.

But to support the lazy load on the codemirror with supported languages, we still have the codemirror-element.html as an asset which still built separately as an html.

We may consider drop the selectively language support and in favor of all-in-one bundle in the future or change build rule to support bundle css in js to move off of the html completely.

UI tests

To run UI tests here will need install dependencies from both npm and bower.

npm run wct-test should take care both for you, read more in package.json.

You will need polymer-bridges which is a submodule you can clone from: https://gerrit-review.googlesource.com/admin/repos/polymer-bridges

As polymer 3 no longer support Polymer.importHref anymore, this plugin still supports it through a custom implementation in gr-editor.js.

Test plugin on Gerrit

  1. Build the bundle locally with: bazel build :codemirror_editor
  2. Serve your generated ‘codemirror_editor.js’ somewhere, you can put it under gerrit/plugins/codemirror-editor/ folder and it will automatically served at http://localhost:8081/plugins_/codemirror-editor/
  3. Use FE dev helper, https://gerrit.googlesource.com/gerrit-fe-dev-helper/, inject the local served ‘codemirror_editor.js’ to the page

If your plugin is already enabled, then you can block it and then inject the compiled local verison.

See more about how to use dev helper extension to help you test here: https://gerrit.googlesource.com/gerrit-fe-dev-helper/+/master