commit f4dfcee3d7f554d82dc063a8ba4b18aff4926785
author Dmitrii Filippov <dmfilippov@google.com> Tue Mar 30 16:11:01 2021 +0200
committer Dmitrii Filippov <dmfilippov@google.com> Tue Mar 30 16:11:01 2021 +0200
tree 3eebd7d5095657eaccff5135ed784315bfad1ae6
parent 51c7340fd4f719eb7daa701431dcca15e138219f

Fix: service users must be ignored when calculating suggestion checkmark

Change-Id: I689c56fcd60ad4080d878e6fadfa9a057f3aeb8a

ui/suggest-owners.js

diff --git a/ui/suggest-owners.js b/ui/suggest-owners.js
index 1233bd5..bf4fff3 100644
--- a/ui/suggest-owners.js
+++ b/ui/suggest-owners.js
@@ -632,7 +632,10 @@
           );
         }
       });
-      if (accounts.length > 0 && suggestion.owners.owned_by_all_users) {
+      const nonServiceUser = account =>
+        !account.tags || account.tags.indexOf('SERVICE_USER') < 0;
+      if (suggestion.owners.owned_by_all_users &&
+          accounts.some(nonServiceUser)) {
         hasSelected = true;
       }
       this.set(['suggestedOwners', sId, 'hasSelected'], hasSelected);