commit da69415ae4578ce05c33c2fa1e5a7c74a70daa77
author Edwin Kempin <ekempin@google.com> Tue May 04 14:06:25 2021 +0000
committer Edwin Kempin <ekempin@google.com> Tue May 04 14:06:25 2021 +0000
tree d3afbca94a8bbad67f2413bf51d2a8ab7c43f198
parent 1cd49c8fb3e75eb48f84b19d89dde1c82be4b81b

CodeOwnerSubmitRule: Only increase rule error metric if RULE_ERROR is returned

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: If65cafa15db03f9f1b87ba47e15c43ebf8fa5415

java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java

diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
index e69616d..df96cc4 100644
--- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
+++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
@@ -146,9 +146,10 @@
         }
       }
       errorMessage += ".";
-      codeOwnerMetrics.countCodeOwnerSubmitRuleErrors.increment(cause);
 
       if (isRuleError) {
+        codeOwnerMetrics.countCodeOwnerSubmitRuleErrors.increment(cause);
+
         logger.atWarning().log(errorMessage);
         return Optional.of(ruleError(errorMessage));
       }