| commit | aece6768ca5dde67cf6df2afd9593f85ac4ceb73 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed May 19 13:13:56 2021 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Wed May 26 14:29:56 2021 +0200 |
| tree | 6a9db54759964ed175936a6403f9623779157480 | |
| parent | d7525247d26fe1384c79e3817ac314ce908b8b61 [diff] |
CodeOwnerApprovalCheck: Do not check twice if a global owner is reviewer getPathCodeOwnerStatus checks early whether any of the reviewers is a global code owner and if yes sets the status to PENDING. In case fallback code owners are evaluated we overrode that status which meant that the fallback code owner logic had to check again whether any of the reviewers was a global code owner. Refactor this so that the check is done only once. This also improves the readability since the fallback code owner logic now only needs to check about fallback code owners, and no longer care about global code owners too. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I9bc8a28d6d7b6950e135abbd979e16641c9c829c
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.