Google Git
Sign in
gerrit/plugins/code-owners/d7525247d26fe1384c79e3817ac314ce908b8b61
commit
d7525247d26fe1384c79e3817ac314ce908b8b61
[log] [tgz]
author
Edwin Kempin <ekempin@google.com>
Wed May 19 13:00:39 2021 +0000
committer
Edwin Kempin <ekempin@google.com>
Wed May 26 14:03:42 2021 +0200
tree
1f959018781f1be6e0d33027e75e715790018189
parent
f6889c778b9adf6925d576e8f0b6781f1c5cb941 [diff]
CodeOwnerApprovalCheck: Drop unreachable code

If a change was code-owner approved by a global code owner the logic for
handling approvals from fallback code owners in
getCodeOwnerStatusForFallbackCodeOwners is not invoked. Hence we can
drop the checks for global code owner approvals there.

Also verified by looking at the test coverage that these lines are never
executed.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I4352392a6d71d09144afbd5f369bc286cae36424
1 file changed
tree: 1f959018781f1be6e0d33027e75e715790018189
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.