CheckedCodeOwnerConfigFileInfoSubject: Drop 'assert' method prefix Without the "assert" prefix chained calls are more readable: assertThat(...).assignsCodeOwnershipToUser() vs. assertThat(...).assertAssignsCodeOwnershipToUser() Change-Id: I0ecdda815efea5fd2c450defc9e0d358f0ee6954 Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/CheckedCodeOwnerConfigFileInfoSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/CheckedCodeOwnerConfigFileInfoSubject.java index ca696e1..effef0c 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/CheckedCodeOwnerConfigFileInfoSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/CheckedCodeOwnerConfigFileInfoSubject.java
@@ -59,12 +59,12 @@ .that(checkedCodeOwnerConfigFileInfo().assignsCodeOwnershipToUser); } - public CheckedCodeOwnerConfigFileInfoSubject assertAssignsCodeOwnershipToUser() { + public CheckedCodeOwnerConfigFileInfoSubject assignsCodeOwnershipToUser() { hasAssignsCodeOwnershipToUserThat().isTrue(); return this; } - public CheckedCodeOwnerConfigFileInfoSubject assertDoesNotAssignCodeOwnershipToUser() { + public CheckedCodeOwnerConfigFileInfoSubject doesNotAssignCodeOwnershipToUser() { hasAssignsCodeOwnershipToUserThat().isFalse(); return this; }
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CheckCodeOwnerIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CheckCodeOwnerIT.java index e7a0e2a..473c3fa 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CheckCodeOwnerIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CheckCodeOwnerIT.java
@@ -173,7 +173,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -216,7 +216,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .element(0) - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooBarCodeOwnerConfigKey) .assertNoWebLinks() @@ -226,7 +226,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .element(1) - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks() @@ -236,7 +236,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .element(2) - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, rootCodeOwnerConfigKey) .assertNoWebLinks() @@ -289,7 +289,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .element(0) - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooBarCodeOwnerConfigKey) .assertNoWebLinks() @@ -299,7 +299,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .element(1) - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks() @@ -342,7 +342,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -375,7 +375,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -410,7 +410,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -459,7 +459,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -495,7 +495,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -534,7 +534,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -572,7 +572,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -611,7 +611,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -652,7 +652,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -701,7 +701,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -738,7 +738,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -776,7 +776,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -864,7 +864,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -910,7 +910,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -950,7 +950,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -1255,7 +1255,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -1316,7 +1316,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertDoesNotAssignCodeOwnershipToUser() + .doesNotAssignCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -1339,7 +1339,7 @@ assertThat(checkCodeOwnerInfo) .hasCheckedCodeOwnerConfigsThat() .onlyElement() - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, codeOwnerConfigKey) .assertNoWebLinks() @@ -1404,7 +1404,7 @@ CheckedCodeOwnerConfigFileInfoSubject codeOwnerConfigFileInfoSubject = assertThat(checkCodeOwnerInfo).hasCheckedCodeOwnerConfigsThat().onlyElement(); codeOwnerConfigFileInfoSubject - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks() @@ -1489,7 +1489,7 @@ CheckedCodeOwnerConfigFileInfoSubject codeOwnerConfigFileInfoSubject = assertThat(checkCodeOwnerInfo).hasCheckedCodeOwnerConfigsThat().onlyElement(); codeOwnerConfigFileInfoSubject - .assertAssignsCodeOwnershipToUser() + .assignsCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks() @@ -1538,7 +1538,7 @@ codeOwnerConfigFileInfoSubject = assertThat(checkCodeOwnerInfo).hasCheckedCodeOwnerConfigsThat().onlyElement(); codeOwnerConfigFileInfoSubject - .assertDoesNotAssignCodeOwnershipToUser() + .doesNotAssignCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks() @@ -1585,7 +1585,7 @@ codeOwnerConfigFileInfoSubject = assertThat(checkCodeOwnerInfo).hasCheckedCodeOwnerConfigsThat().onlyElement(); codeOwnerConfigFileInfoSubject - .assertDoesNotAssignCodeOwnershipToUser() + .doesNotAssignCodeOwnershipToUser() .hasCodeOwnerConfigFileThat() .assertKey(backend, fooCodeOwnerConfigKey) .assertNoWebLinks()