commit 7664d5220d55eab009ae3d624c09f33d02bd10f0
author Edwin Kempin <ekempin@google.com> Mon Mar 01 17:30:28 2021 +0100
committer Edwin Kempin <ekempin@google.com> Mon Mar 01 17:31:37 2021 +0100
tree d4b3dda57902ebdab5e3a51e7e056cb6f82d5b80
parent d2e69e6aa2af17ee3a156d7ade4c7f76224cd6ba

Add metric to count the number of code owner submit rule runs

We a trying to remove unnecessary submit rule invocations. Having this
metric helps to show the impact of such fixes.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Iea433d147f3f5feba7865adc3d47ef67086a19eb

java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java

diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
index 0683b25..1785a1d 100644
--- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
+++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
@@ -78,6 +78,7 @@
       }
 
       try (Timer0.Context ctx = codeOwnerMetrics.runCodeOwnerSubmitRule.start()) {
+        codeOwnerMetrics.countCodeOwnerConfigReads.increment();
         logger.atFine().log(
             "run code owner submit rule (project = %s, change = %d)",
             changeData.project().get(), changeData.getId().get());

java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java

diff --git a/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java b/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
index 2f3ce40..56aec3c 100644
--- a/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
+++ b/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
@@ -49,6 +49,7 @@
   // counter metrics
   public final Counter0 countCodeOwnerConfigReads;
   public final Counter0 countCodeOwnerConfigCacheReads;
+  public final Counter0 countCodeOwnerSubmitRuleRuns;
 
   private final MetricMaker metricMaker;
 
@@ -123,6 +124,9 @@
         createCounter(
             "count_code_owner_config_cache_reads",
             "Total number of code owner config reads from cache");
+    this.countCodeOwnerSubmitRuleRuns =
+        createCounter(
+            "count_code_owner_submit_rule_runs", "Total number of code owner submit rule runs");
   }
 
   private Timer0 createLatencyTimer(String name, String description) {

resources/Documentation/metrics.md

diff --git a/resources/Documentation/metrics.md b/resources/Documentation/metrics.md
index 481c61a..3abb6f8 100644
--- a/resources/Documentation/metrics.md
+++ b/resources/Documentation/metrics.md
@@ -45,6 +45,8 @@
   Total number of code owner config reads from backend.
 * `count_code_owner_config_cache_reads`:
   Total number of code owner config reads from cache.
+* `count_code_owner_submit_rule_runs`:
+  Total number of code owner submit rule runs.
 
 ---