Move API impl classes into a separate package This is a step towards splitting the monolithic plugin target across java packages. Also-by: David Ostrovsky <david@ostrovsky.org> Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ibf1406570c3eebb86e93d9fba1ce425de9a96ef3
diff --git a/java/com/google/gerrit/plugins/codeowners/acceptance/AbstractCodeOwnersIT.java b/java/com/google/gerrit/plugins/codeowners/acceptance/AbstractCodeOwnersIT.java index da0b172..ec40999 100644 --- a/java/com/google/gerrit/plugins/codeowners/acceptance/AbstractCodeOwnersIT.java +++ b/java/com/google/gerrit/plugins/codeowners/acceptance/AbstractCodeOwnersIT.java
@@ -18,10 +18,10 @@ import com.google.common.collect.ImmutableMap; import com.google.gerrit.plugins.codeowners.acceptance.testsuite.CodeOwnerConfigOperations; -import com.google.gerrit.plugins.codeowners.api.ChangeCodeOwnersFactory; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigsFactory; -import com.google.gerrit.plugins.codeowners.api.CodeOwnersFactory; -import com.google.gerrit.plugins.codeowners.api.ProjectCodeOwnersFactory; +import com.google.gerrit.plugins.codeowners.api.impl.ChangeCodeOwnersFactory; +import com.google.gerrit.plugins.codeowners.api.impl.CodeOwnerConfigsFactory; +import com.google.gerrit.plugins.codeowners.api.impl.CodeOwnersFactory; +import com.google.gerrit.plugins.codeowners.api.impl.ProjectCodeOwnersFactory; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackendId; import com.google.gerrit.plugins.codeowners.config.BackendConfig; import com.google.gerrit.testing.ConfigSuite;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwners.java b/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwners.java index 8c1a7dd..21731a6 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwners.java +++ b/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwners.java
@@ -20,7 +20,7 @@ /** * Java API for change code owners. * - * <p>To create an instance for a change use {@link ChangeCodeOwnersFactory}. + * <p>To create an instance for a change use {@code ChangeCodeOwnersFactory}. */ public interface ChangeCodeOwners { /** Returns the code owner status for the files in the change. */
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigs.java b/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigs.java index 24e054c..8754809 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigs.java +++ b/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigs.java
@@ -23,7 +23,7 @@ /** * Java API for code owners configs in a branch. * - * <p>To create an instance for a branch use {@link CodeOwnerConfigsFactory}. + * <p>To create an instance for a branch use {@code CodeOwnerConfigsFactory}. */ public interface CodeOwnerConfigs { /**
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwners.java b/java/com/google/gerrit/plugins/codeowners/api/CodeOwners.java index 1cf6e9e..e88bdb8 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwners.java +++ b/java/com/google/gerrit/plugins/codeowners/api/CodeOwners.java
@@ -31,7 +31,7 @@ /** * Java API for code owners in a branch or change revision. * - * <p>To create an instance for a branch or change revision use {@link CodeOwnersFactory}. + * <p>To create an instance for a branch or change revision use {@code CodeOwnersFactory}. */ public interface CodeOwners { /** Query code owners for a path. */
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwners.java b/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwners.java index ccce1ed..89fbacf 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwners.java +++ b/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwners.java
@@ -25,7 +25,7 @@ /** * Project-level Java API of the code-owners plugin. * - * <p>To create an instance for a project use {@link ProjectCodeOwnersFactory}. + * <p>To create an instance for a project use {@code ProjectCodeOwnersFactory}. */ public interface ProjectCodeOwners { /** Returns the code owner project configuration. */
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ApiModule.java b/java/com/google/gerrit/plugins/codeowners/api/impl/ApiModule.java similarity index 95% rename from java/com/google/gerrit/plugins/codeowners/api/ApiModule.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/ApiModule.java index 92fce1e..838f2f8 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ApiModule.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/ApiModule.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import com.google.gerrit.extensions.config.FactoryModule;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/BranchCodeOwnersImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/BranchCodeOwnersImpl.java similarity index 87% rename from java/com/google/gerrit/plugins/codeowners/api/BranchCodeOwnersImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/BranchCodeOwnersImpl.java index beae1f6..81a418c 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/BranchCodeOwnersImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/BranchCodeOwnersImpl.java
@@ -12,11 +12,18 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.BranchCodeOwners; +import com.google.gerrit.plugins.codeowners.api.BranchCodeOwners.CodeOwnerCheckRequest; +import com.google.gerrit.plugins.codeowners.api.BranchCodeOwners.CodeOwnerConfigFilesRequest; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerBranchConfigInfo; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerCheckInfo; +import com.google.gerrit.plugins.codeowners.api.RenameEmailInput; +import com.google.gerrit.plugins.codeowners.api.RenameEmailResultInfo; import com.google.gerrit.plugins.codeowners.restapi.CheckCodeOwner; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnerBranchConfig; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnerConfigFiles;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersFactory.java b/java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersFactory.java similarity index 93% rename from java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersFactory.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersFactory.java index 732c9e7..5c7535f 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersFactory.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersFactory.java
@@ -12,13 +12,15 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.TopLevelResource; +import com.google.gerrit.plugins.codeowners.api.ChangeCodeOwners; +import com.google.gerrit.plugins.codeowners.api.CodeOwners; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.restapi.change.ChangesCollection; import com.google.inject.Inject;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersImpl.java similarity index 90% rename from java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersImpl.java index ad6ed18..9f266f8 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ChangeCodeOwnersImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/ChangeCodeOwnersImpl.java
@@ -12,12 +12,15 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.ChangeCodeOwners; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatusInfo; +import com.google.gerrit.plugins.codeowners.api.RevisionCodeOwners; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnerStatus; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.change.RevisionResource;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsFactory.java b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsFactory.java similarity index 96% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsFactory.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsFactory.java index 0be3d07..f11c9ed 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsFactory.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsFactory.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; @@ -21,6 +21,7 @@ import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.TopLevelResource; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigs; import com.google.gerrit.server.project.BranchResource; import com.google.gerrit.server.project.ProjectResource; import com.google.gerrit.server.restapi.project.BranchesCollection;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsInBranchImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsInBranchImpl.java similarity index 93% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsInBranchImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsInBranchImpl.java index 54573b2..27b90b7 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigsInBranchImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnerConfigsInBranchImpl.java
@@ -12,13 +12,15 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigInfo; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigs; import com.google.gerrit.plugins.codeowners.restapi.CodeOwnerConfigsInBranchCollection; import com.google.gerrit.plugins.codeowners.restapi.CodeOwnerConfigsInBranchCollection.PathResource; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnerConfigForPathInBranch;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersFactory.java b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersFactory.java similarity index 97% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnersFactory.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersFactory.java index 28acd8a..b5bc249 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersFactory.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersFactory.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; @@ -21,6 +21,7 @@ import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.TopLevelResource; +import com.google.gerrit.plugins.codeowners.api.CodeOwners; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.change.RevisionResource; import com.google.gerrit.server.project.BranchResource;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInBranchImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInBranchImpl.java similarity index 91% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInBranchImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInBranchImpl.java index 27dc958..f9e3fdf 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInBranchImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInBranchImpl.java
@@ -12,12 +12,15 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerInfo; +import com.google.gerrit.plugins.codeowners.api.CodeOwners; +import com.google.gerrit.plugins.codeowners.api.CodeOwners.QueryRequest; import com.google.gerrit.plugins.codeowners.restapi.CodeOwnersInBranchCollection; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnersForPathInBranch; import com.google.gerrit.server.project.BranchResource;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInChangeImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInChangeImpl.java similarity index 92% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInChangeImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInChangeImpl.java index e5a25a3..d1281fd 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnersInChangeImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/CodeOwnersInChangeImpl.java
@@ -12,13 +12,16 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerInfo; +import com.google.gerrit.plugins.codeowners.api.CodeOwners; +import com.google.gerrit.plugins.codeowners.api.CodeOwners.QueryRequest; import com.google.gerrit.plugins.codeowners.restapi.CodeOwnersInChangeCollection; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnersForPathInChange; import com.google.gerrit.server.change.RevisionResource;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersFactory.java b/java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersFactory.java similarity index 95% rename from java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersFactory.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersFactory.java index 633eebb..cb85a1f 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersFactory.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersFactory.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; @@ -20,6 +20,7 @@ import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.TopLevelResource; +import com.google.gerrit.plugins.codeowners.api.ProjectCodeOwners; import com.google.gerrit.server.project.ProjectResource; import com.google.gerrit.server.restapi.project.ProjectsCollection; import com.google.inject.Inject;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersImpl.java similarity index 89% rename from java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersImpl.java index 54b37ec..7d578e5 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/ProjectCodeOwnersImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/ProjectCodeOwnersImpl.java
@@ -12,13 +12,18 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.api.config.ConsistencyCheckInfo.ConsistencyProblemInfo; import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.BranchCodeOwners; +import com.google.gerrit.plugins.codeowners.api.CheckCodeOwnerConfigFilesInput; +import com.google.gerrit.plugins.codeowners.api.CodeOwnerProjectConfigInfo; +import com.google.gerrit.plugins.codeowners.api.ProjectCodeOwners; +import com.google.gerrit.plugins.codeowners.api.ProjectCodeOwners.CheckCodeOwnerConfigFilesRequest; import com.google.gerrit.plugins.codeowners.restapi.CheckCodeOwnerConfigFiles; import com.google.gerrit.plugins.codeowners.restapi.GetCodeOwnerProjectConfig; import com.google.gerrit.server.project.BranchResource;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/RevisionCodeOwnersImpl.java b/java/com/google/gerrit/plugins/codeowners/api/impl/RevisionCodeOwnersImpl.java similarity index 88% rename from java/com/google/gerrit/plugins/codeowners/api/RevisionCodeOwnersImpl.java rename to java/com/google/gerrit/plugins/codeowners/api/impl/RevisionCodeOwnersImpl.java index 817639f..a4ea2bd 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/RevisionCodeOwnersImpl.java +++ b/java/com/google/gerrit/plugins/codeowners/api/impl/RevisionCodeOwnersImpl.java
@@ -12,12 +12,15 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.api.impl; import static com.google.gerrit.server.api.ApiUtil.asRestApiException; import com.google.gerrit.extensions.api.config.ConsistencyCheckInfo.ConsistencyProblemInfo; import com.google.gerrit.extensions.restapi.RestApiException; +import com.google.gerrit.plugins.codeowners.api.CheckCodeOwnerConfigFilesInRevisionInput; +import com.google.gerrit.plugins.codeowners.api.RevisionCodeOwners; +import com.google.gerrit.plugins.codeowners.api.RevisionCodeOwners.CheckCodeOwnerConfigFilesRequest; import com.google.gerrit.plugins.codeowners.restapi.CheckCodeOwnerConfigFilesInRevision; import com.google.gerrit.server.change.RevisionResource; import com.google.inject.Inject;
diff --git a/java/com/google/gerrit/plugins/codeowners/module/Module.java b/java/com/google/gerrit/plugins/codeowners/module/Module.java index 733ebe2..1c362f4 100644 --- a/java/com/google/gerrit/plugins/codeowners/module/Module.java +++ b/java/com/google/gerrit/plugins/codeowners/module/Module.java
@@ -15,7 +15,7 @@ package com.google.gerrit.plugins.codeowners.module; import com.google.gerrit.extensions.config.FactoryModule; -import com.google.gerrit.plugins.codeowners.api.ApiModule; +import com.google.gerrit.plugins.codeowners.api.impl.ApiModule; import com.google.gerrit.plugins.codeowners.backend.BackendModule; import com.google.gerrit.plugins.codeowners.config.ConfigModule; import com.google.gerrit.plugins.codeowners.restapi.RestApiModule;