Include revision into error message when rejecting invalid import Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I697dc20f17743dfa002ed4c90d5d4698f020382b
diff --git a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java index 17235cd..9458289 100644 --- a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java +++ b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java
@@ -872,10 +872,11 @@ importType, codeOwnerConfigFilePath, String.format( - "'%s' does not exist (project = %s, branch = %s)", + "'%s' does not exist (project = %s, branch = %s, revision = %s)", codeOwnerConfigReference.filePath(), keyOfImportedCodeOwnerConfig.branchNameKey().project().get(), - keyOfImportedCodeOwnerConfig.branchNameKey().shortName())); + keyOfImportedCodeOwnerConfig.branchNameKey().shortName(), + revision.get().name())); } } catch (StorageException storageException) { if (getInvalidConfigCause(storageException).isPresent()) {
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java index fe9bdc1..8a69e44 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java
@@ -1355,13 +1355,15 @@ r, "invalid code owner config files", String.format( - "invalid %s import in '%s': '%s' does not exist (project = %s, branch = master)", + "invalid %s import in '%s': '%s' does not exist (project = %s, branch = master," + + " revision = %s)", importType.getType(), codeOwnerConfigOperations.codeOwnerConfig(keyOfImportingCodeOwnerConfig).getFilePath(), codeOwnerConfigOperations .codeOwnerConfig(keyOfNonExistingCodeOwnerConfig) .getFilePath(), - project.get())); + project.get(), + r.getCommit().name())); } @Test