Move classes that are shared between API and impl into a common package This is a step towards splitting the monolithic plugin target across java packages. Also-by: David Ostrovsky <david@ostrovsky.org> Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I60497f11e34284a3f89178eed8e05cd3c0ba6327
diff --git a/java/com/google/gerrit/plugins/codeowners/api/GeneralInfo.java b/java/com/google/gerrit/plugins/codeowners/api/GeneralInfo.java index 8caa0fe..2f4a133 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/GeneralInfo.java +++ b/java/com/google/gerrit/plugins/codeowners/api/GeneralInfo.java
@@ -15,6 +15,7 @@ package com.google.gerrit.plugins.codeowners.api; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; /** * Representation of the general code owners configuration in the REST API.
diff --git a/java/com/google/gerrit/plugins/codeowners/api/PathCodeOwnerStatusInfo.java b/java/com/google/gerrit/plugins/codeowners/api/PathCodeOwnerStatusInfo.java index 80e1f70..7643e53 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/PathCodeOwnerStatusInfo.java +++ b/java/com/google/gerrit/plugins/codeowners/api/PathCodeOwnerStatusInfo.java
@@ -14,6 +14,8 @@ package com.google.gerrit.plugins.codeowners.api; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; + /** JSON entity that describes the code owner status for a path that was touched in a change. */ public class PathCodeOwnerStatusInfo { /**
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/ChangedFiles.java b/java/com/google/gerrit/plugins/codeowners/backend/ChangedFiles.java index 57e72ef..1b836fe 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/ChangedFiles.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/ChangedFiles.java
@@ -23,7 +23,8 @@ import com.google.gerrit.entities.Patch; import com.google.gerrit.entities.Project; import com.google.gerrit.extensions.client.DiffPreferencesInfo.Whitespace; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.server.change.RevisionResource; import com.google.gerrit.server.git.GitRepositoryManager;
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java index efbb831..0a1f837 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java
@@ -28,7 +28,8 @@ import com.google.gerrit.entities.Project; import com.google.gerrit.exceptions.StorageException; import com.google.gerrit.extensions.restapi.ResourceConflictException; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.plugins.codeowners.config.RequiredApproval; import com.google.gerrit.server.ApprovalsUtil;
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java index 829058a..8f07807 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java
@@ -23,7 +23,7 @@ import com.google.gerrit.entities.Account; import com.google.gerrit.entities.PatchSet; import com.google.gerrit.extensions.restapi.ResourceConflictException; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.plugins.codeowners.config.RequiredApproval; import com.google.gerrit.plugins.codeowners.util.JgitPath;
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/FileCodeOwnerStatus.java b/java/com/google/gerrit/plugins/codeowners/backend/FileCodeOwnerStatus.java index 3d084db..34ff019 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/FileCodeOwnerStatus.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/FileCodeOwnerStatus.java
@@ -15,6 +15,7 @@ package com.google.gerrit.plugins.codeowners.backend; import com.google.auto.value.AutoValue; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; import java.util.Optional; /** Code owner status for a particular file that was changed in a change. */
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnerStatus.java b/java/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnerStatus.java index 9285a52..9f4b87e 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnerStatus.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnerStatus.java
@@ -15,7 +15,7 @@ package com.google.gerrit.plugins.codeowners.backend; import com.google.auto.value.AutoValue; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import java.nio.file.Path; /** Code owner status for a particular path that has been modified in a change. */
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/ChangedFile.java b/java/com/google/gerrit/plugins/codeowners/common/ChangedFile.java similarity index 98% rename from java/com/google/gerrit/plugins/codeowners/backend/ChangedFile.java rename to java/com/google/gerrit/plugins/codeowners/common/ChangedFile.java index 5838d1f..3d2caec 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/ChangedFile.java +++ b/java/com/google/gerrit/plugins/codeowners/common/ChangedFile.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.backend; +package com.google.gerrit.plugins.codeowners.common; import static com.google.common.base.Preconditions.checkState; import static java.util.Objects.requireNonNull;
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigValidationPolicy.java b/java/com/google/gerrit/plugins/codeowners/common/CodeOwnerConfigValidationPolicy.java similarity index 95% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigValidationPolicy.java rename to java/com/google/gerrit/plugins/codeowners/common/CodeOwnerConfigValidationPolicy.java index db1e6ca..5976c71 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerConfigValidationPolicy.java +++ b/java/com/google/gerrit/plugins/codeowners/common/CodeOwnerConfigValidationPolicy.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.common; /** Policy that should be used to validate code owner config files. */ public enum CodeOwnerConfigValidationPolicy {
diff --git a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerStatus.java b/java/com/google/gerrit/plugins/codeowners/common/CodeOwnerStatus.java similarity index 95% rename from java/com/google/gerrit/plugins/codeowners/api/CodeOwnerStatus.java rename to java/com/google/gerrit/plugins/codeowners/common/CodeOwnerStatus.java index 1873b23..3af1c44 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/CodeOwnerStatus.java +++ b/java/com/google/gerrit/plugins/codeowners/common/CodeOwnerStatus.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.common; /** Code owner status for a path in a change. */ public enum CodeOwnerStatus {
diff --git a/java/com/google/gerrit/plugins/codeowners/api/MergeCommitStrategy.java b/java/com/google/gerrit/plugins/codeowners/common/MergeCommitStrategy.java similarity index 97% rename from java/com/google/gerrit/plugins/codeowners/api/MergeCommitStrategy.java rename to java/com/google/gerrit/plugins/codeowners/common/MergeCommitStrategy.java index 96894a9..da9c76d 100644 --- a/java/com/google/gerrit/plugins/codeowners/api/MergeCommitStrategy.java +++ b/java/com/google/gerrit/plugins/codeowners/common/MergeCommitStrategy.java
@@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.plugins.codeowners.api; +package com.google.gerrit.plugins.codeowners.common; /** Strategy that defines for merge commits which files require code owner approvals. */ public enum MergeCommitStrategy {
diff --git a/java/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfiguration.java b/java/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfiguration.java index f55642b..fe18fb8 100644 --- a/java/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfiguration.java +++ b/java/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfiguration.java
@@ -27,11 +27,11 @@ import com.google.gerrit.entities.Project; import com.google.gerrit.extensions.annotations.PluginName; import com.google.gerrit.extensions.restapi.MethodNotAllowedException; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigValidationPolicy; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackend; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerReference; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerConfigValidationPolicy; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.server.config.PluginConfigFactory; import com.google.gerrit.server.project.NoSuchProjectException; import com.google.gerrit.server.project.ProjectCache;
diff --git a/java/com/google/gerrit/plugins/codeowners/config/GeneralConfig.java b/java/com/google/gerrit/plugins/codeowners/config/GeneralConfig.java index cafe8e7..cdd17ad 100644 --- a/java/com/google/gerrit/plugins/codeowners/config/GeneralConfig.java +++ b/java/com/google/gerrit/plugins/codeowners/config/GeneralConfig.java
@@ -25,10 +25,10 @@ import com.google.common.flogger.FluentLogger; import com.google.gerrit.entities.Project; import com.google.gerrit.extensions.annotations.PluginName; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigValidationPolicy; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerReference; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerConfigValidationPolicy; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.server.config.PluginConfig; import com.google.gerrit.server.config.PluginConfigFactory; import com.google.gerrit.server.git.validators.CommitValidationMessage;
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/ChangedFileSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/ChangedFileSubject.java index b83bde2..805eccd 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/ChangedFileSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/ChangedFileSubject.java
@@ -19,7 +19,7 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.Subject; -import com.google.gerrit.plugins.codeowners.backend.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; import com.google.gerrit.truth.OptionalSubject; /** {@link Subject} for doing assertions on {@link ChangedFile}s. */
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusInfoSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusInfoSubject.java index 4671d8d..0ed2f75 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusInfoSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusInfoSubject.java
@@ -19,8 +19,8 @@ import com.google.common.truth.ComparableSubject; import com.google.common.truth.FailureMetadata; import com.google.common.truth.Subject; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.api.PathCodeOwnerStatusInfo; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; /** {@link Subject} for doing assertions on {@link PathCodeOwnerStatusInfo}s. */ public class PathCodeOwnerStatusInfoSubject extends Subject {
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusSubject.java index 47bea0e..a99c0e6 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/PathCodeOwnerStatusSubject.java
@@ -21,8 +21,8 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.PathSubject; import com.google.common.truth.Subject; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.backend.PathCodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; /** {@link Subject} for doing assertions on {@link PathCodeOwnerStatus}s. */ public class PathCodeOwnerStatusSubject extends Subject {
diff --git a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java index 17c1255..08915e4 100644 --- a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java +++ b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java
@@ -29,9 +29,6 @@ import com.google.gerrit.entities.PatchSet; import com.google.gerrit.entities.Project; import com.google.gerrit.exceptions.StorageException; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigValidationPolicy; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; -import com.google.gerrit.plugins.codeowners.backend.ChangedFile; import com.google.gerrit.plugins.codeowners.backend.ChangedFiles; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackend; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerConfig; @@ -40,6 +37,9 @@ import com.google.gerrit.plugins.codeowners.backend.CodeOwnerReference; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerResolver; import com.google.gerrit.plugins.codeowners.backend.PathCodeOwners; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerConfigValidationPolicy; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.plugins.codeowners.config.InvalidPluginConfigurationException; import com.google.gerrit.plugins.codeowners.util.JgitPath;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java index dbc8944..1e74951 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java
@@ -29,8 +29,8 @@ import com.google.gerrit.extensions.common.ChangeInfo; import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatusInfo; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.testing.SubmitRequirementInfoSubject; import org.junit.Test;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnersPluginConfigValidatorIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnersPluginConfigValidatorIT.java index e22062e..01ff95b 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnersPluginConfigValidatorIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnersPluginConfigValidatorIT.java
@@ -24,10 +24,10 @@ import com.google.gerrit.entities.BranchNameKey; import com.google.gerrit.entities.RefNames; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackendId; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; import com.google.gerrit.plugins.codeowners.backend.proto.ProtoBackend; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.BackendConfig; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.plugins.codeowners.config.GeneralConfig;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerBranchConfigIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerBranchConfigIT.java index a838795..ef9a688 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerBranchConfigIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerBranchConfigIT.java
@@ -26,10 +26,10 @@ import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; import com.google.gerrit.plugins.codeowners.api.CodeOwnerBranchConfigInfo; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackend; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackendId; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.BackendConfig; import com.google.gerrit.plugins.codeowners.config.GeneralConfig; import com.google.gerrit.plugins.codeowners.config.OverrideApprovalConfig;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerProjectConfigIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerProjectConfigIT.java index fe6c044..39ea0fe 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerProjectConfigIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerProjectConfigIT.java
@@ -30,10 +30,10 @@ import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; import com.google.gerrit.plugins.codeowners.api.CodeOwnerProjectConfigInfo; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackend; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackendId; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.BackendConfig; import com.google.gerrit.plugins.codeowners.config.GeneralConfig; import com.google.gerrit.plugins.codeowners.config.OverrideApprovalConfig;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerStatusIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerStatusIT.java index 9b1e590..b0da402 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerStatusIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/GetCodeOwnerStatusIT.java
@@ -21,8 +21,8 @@ import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations; import com.google.gerrit.extensions.common.ChangeType; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatusInfo; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusInfoSubject; import com.google.inject.Inject; import org.junit.Test;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFileTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFileTest.java index a05799d..6abb86e 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFileTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFileTest.java
@@ -22,6 +22,7 @@ import com.google.gerrit.common.Nullable; import com.google.gerrit.entities.Patch; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; import com.google.gerrit.server.patch.PatchListEntry; import java.nio.file.Paths; import org.eclipse.jgit.diff.DiffEntry;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFilesTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFilesTest.java index db73a2f..2acf24b 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFilesTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/ChangedFilesTest.java
@@ -33,7 +33,8 @@ import com.google.gerrit.extensions.restapi.IdString; import com.google.gerrit.extensions.restapi.TopLevelResource; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.util.JgitPath; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.change.RevisionResource;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckForAccountTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckForAccountTest.java index 216504f..59930d1 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckForAccountTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckForAccountTest.java
@@ -23,7 +23,7 @@ import com.google.gerrit.entities.Change; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; import com.google.gerrit.plugins.codeowners.acceptance.testsuite.CodeOwnerConfigOperations; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath; import com.google.gerrit.server.notedb.ChangeNotes;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckTest.java index f8edcd1..59a6e64 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckTest.java
@@ -37,7 +37,7 @@ import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; import com.google.gerrit.plugins.codeowners.acceptance.testsuite.CodeOwnerConfigOperations; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath; import com.google.gerrit.server.notedb.ChangeNotes;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithAllUsersAsFallbackCodeOwnersTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithAllUsersAsFallbackCodeOwnersTest.java index dd40600..9a9707a 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithAllUsersAsFallbackCodeOwnersTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithAllUsersAsFallbackCodeOwnersTest.java
@@ -22,7 +22,7 @@ import com.google.gerrit.entities.Change; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; import com.google.gerrit.plugins.codeowners.acceptance.testsuite.CodeOwnerConfigOperations; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.config.GeneralConfig; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithSelfApprovalsIgnoredTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithSelfApprovalsIgnoredTest.java index 253cfbc..032cfda 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithSelfApprovalsIgnoredTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheckWithSelfApprovalsIgnoredTest.java
@@ -23,7 +23,7 @@ import com.google.gerrit.extensions.api.changes.ReviewInput; import com.google.gerrit.extensions.common.LabelDefinitionInput; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.config.OverrideApprovalConfig; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfigurationTest.java b/javatests/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfigurationTest.java index f03427d..2277bd4 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfigurationTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/config/CodeOwnersPluginConfigurationTest.java
@@ -35,12 +35,12 @@ import com.google.gerrit.extensions.registration.RegistrationHandle; import com.google.gerrit.extensions.restapi.MethodNotAllowedException; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackend; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerConfig; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerConfigUpdate; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; import com.google.gerrit.plugins.codeowners.backend.findowners.FindOwnersBackend; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.server.IdentifiedUser; import com.google.inject.Inject; import com.google.inject.Key;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/config/GeneralConfigTest.java b/javatests/com/google/gerrit/plugins/codeowners/config/GeneralConfigTest.java index 78adae8..5ab585b 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/config/GeneralConfigTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/config/GeneralConfigTest.java
@@ -34,10 +34,10 @@ import com.google.common.collect.Iterables; import com.google.gerrit.acceptance.config.GerritConfig; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerConfigValidationPolicy; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerReference; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerConfigValidationPolicy; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.server.git.validators.CommitValidationMessage; import com.google.gerrit.server.git.validators.ValidationMessage; import com.google.gerrit.server.project.ProjectLevelConfig;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerProjectConfigJsonTest.java b/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerProjectConfigJsonTest.java index 51b6ea5..3042859 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerProjectConfigJsonTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerProjectConfigJsonTest.java
@@ -31,13 +31,13 @@ import com.google.gerrit.plugins.codeowners.api.CodeOwnerBranchConfigInfo; import com.google.gerrit.plugins.codeowners.api.CodeOwnerProjectConfigInfo; import com.google.gerrit.plugins.codeowners.api.CodeOwnersStatusInfo; -import com.google.gerrit.plugins.codeowners.api.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.api.RequiredApprovalInfo; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerBackendId; import com.google.gerrit.plugins.codeowners.backend.CodeOwnerConfigScanner; import com.google.gerrit.plugins.codeowners.backend.FallbackCodeOwners; import com.google.gerrit.plugins.codeowners.backend.findowners.FindOwnersBackend; import com.google.gerrit.plugins.codeowners.backend.proto.ProtoBackend; +import com.google.gerrit.plugins.codeowners.common.MergeCommitStrategy; import com.google.gerrit.plugins.codeowners.config.CodeOwnersPluginConfiguration; import com.google.gerrit.plugins.codeowners.config.RequiredApproval; import com.google.gerrit.server.CurrentUser;
diff --git a/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerStatusInfoJsonTest.java b/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerStatusInfoJsonTest.java index 75aaeef..456e609 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerStatusInfoJsonTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/restapi/CodeOwnerStatusInfoJsonTest.java
@@ -27,13 +27,13 @@ import com.google.gerrit.entities.PatchSet; import com.google.gerrit.extensions.common.ChangeType; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; -import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatusInfo; import com.google.gerrit.plugins.codeowners.api.FileCodeOwnerStatusInfo; import com.google.gerrit.plugins.codeowners.api.PathCodeOwnerStatusInfo; -import com.google.gerrit.plugins.codeowners.backend.ChangedFile; import com.google.gerrit.plugins.codeowners.backend.FileCodeOwnerStatus; import com.google.gerrit.plugins.codeowners.backend.PathCodeOwnerStatus; +import com.google.gerrit.plugins.codeowners.common.ChangedFile; +import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; import com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusInfoSubject; import com.google.gerrit.truth.ListSubject; import java.nio.file.Paths;