Adapt to change in Gerrit core Change Ib55038627 in Gerrit core renamed SubmitRequirement and SubmitRequirementInfo. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I5e33facc298d868ccf16951a79a95f61b4d268bf
diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java index 011e8cf..ea0f38a 100644 --- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java +++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRule.java
@@ -18,8 +18,8 @@ import com.google.common.collect.ImmutableList; import com.google.common.flogger.FluentLogger; +import com.google.gerrit.entities.LegacySubmitRequirement; import com.google.gerrit.entities.SubmitRecord; -import com.google.gerrit.entities.SubmitRequirement; import com.google.gerrit.extensions.annotations.Exports; import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.extensions.restapi.RestApiException; @@ -51,8 +51,11 @@ } } - private static final SubmitRequirement SUBMIT_REQUIREMENT = - SubmitRequirement.builder().setFallbackText("Code Owners").setType("code-owners").build(); + private static final LegacySubmitRequirement SUBMIT_REQUIREMENT = + LegacySubmitRequirement.builder() + .setFallbackText("Code Owners") + .setType("code-owners") + .build(); private final CodeOwnersPluginConfiguration codeOwnersPluginConfiguration; private final CodeOwnerApprovalCheck codeOwnerApprovalCheck;
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementInfoSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementInfoSubject.java similarity index 68% rename from java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementInfoSubject.java rename to java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementInfoSubject.java index dbe7848..9c8d2cb 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementInfoSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementInfoSubject.java
@@ -18,27 +18,27 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.StringSubject; import com.google.common.truth.Subject; -import com.google.gerrit.extensions.common.SubmitRequirementInfo; +import com.google.gerrit.extensions.common.LegacySubmitRequirementInfo; import com.google.gerrit.truth.ListSubject; import java.util.Collection; -/** {@link Subject} for doing assertions on {@link SubmitRequirementInfo}s. */ -public class SubmitRequirementInfoSubject extends Subject { - public static ListSubject<SubmitRequirementInfoSubject, SubmitRequirementInfo> - assertThatCollection(Collection<SubmitRequirementInfo> submitRequirementInfos) { +/** {@link Subject} for doing assertions on {@link LegacySubmitRequirementInfo}s. */ +public class LegacySubmitRequirementInfoSubject extends Subject { + public static ListSubject<LegacySubmitRequirementInfoSubject, LegacySubmitRequirementInfo> + assertThatCollection(Collection<LegacySubmitRequirementInfo> submitRequirementInfos) { return ListSubject.assertThat( ImmutableList.copyOf(submitRequirementInfos), submitRecordRequirementInfos()); } - private static Factory<SubmitRequirementInfoSubject, SubmitRequirementInfo> + private static Factory<LegacySubmitRequirementInfoSubject, LegacySubmitRequirementInfo> submitRecordRequirementInfos() { - return SubmitRequirementInfoSubject::new; + return LegacySubmitRequirementInfoSubject::new; } - private final SubmitRequirementInfo submitRequirementInfo; + private final LegacySubmitRequirementInfo submitRequirementInfo; - private SubmitRequirementInfoSubject( - FailureMetadata metadata, SubmitRequirementInfo submitRequirementInfo) { + private LegacySubmitRequirementInfoSubject( + FailureMetadata metadata, LegacySubmitRequirementInfo submitRequirementInfo) { super(metadata, submitRequirementInfo); this.submitRequirementInfo = submitRequirementInfo; } @@ -58,7 +58,7 @@ return check("fallbackText()").that(submitRequirementInfo().fallbackText); } - private SubmitRequirementInfo submitRequirementInfo() { + private LegacySubmitRequirementInfo submitRequirementInfo() { isNotNull(); return submitRequirementInfo; }
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementSubject.java similarity index 68% rename from java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementSubject.java rename to java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementSubject.java index 7ffd31c..8a2fb99 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRequirementSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/LegacySubmitRequirementSubject.java
@@ -17,17 +17,19 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.StringSubject; import com.google.common.truth.Subject; -import com.google.gerrit.entities.SubmitRequirement; +import com.google.gerrit.entities.LegacySubmitRequirement; -/** {@link Subject} for doing assertions on {@link SubmitRequirement}s. */ -public class SubmitRequirementSubject extends Subject { - public static Factory<SubmitRequirementSubject, SubmitRequirement> submitRecordRequirements() { - return SubmitRequirementSubject::new; +/** {@link Subject} for doing assertions on {@link LegacySubmitRequirement}s. */ +public class LegacySubmitRequirementSubject extends Subject { + public static Factory<LegacySubmitRequirementSubject, LegacySubmitRequirement> + submitRecordRequirements() { + return LegacySubmitRequirementSubject::new; } - private final SubmitRequirement submitRequirement; + private final LegacySubmitRequirement submitRequirement; - private SubmitRequirementSubject(FailureMetadata metadata, SubmitRequirement submitRequirement) { + private LegacySubmitRequirementSubject( + FailureMetadata metadata, LegacySubmitRequirement submitRequirement) { super(metadata, submitRequirement); this.submitRequirement = submitRequirement; } @@ -42,7 +44,7 @@ return check("fallbackText()").that(submitRequirement().fallbackText()); } - private SubmitRequirement submitRequirement() { + private LegacySubmitRequirement submitRequirement() { isNotNull(); return submitRequirement; }
diff --git a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRecordSubject.java b/java/com/google/gerrit/plugins/codeowners/testing/SubmitRecordSubject.java index 7b45e8b..aa727b5 100644 --- a/java/com/google/gerrit/plugins/codeowners/testing/SubmitRecordSubject.java +++ b/java/com/google/gerrit/plugins/codeowners/testing/SubmitRecordSubject.java
@@ -14,14 +14,14 @@ package com.google.gerrit.plugins.codeowners.testing; -import static com.google.gerrit.plugins.codeowners.testing.SubmitRequirementSubject.submitRecordRequirements; +import static com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementSubject.submitRecordRequirements; import static com.google.gerrit.truth.ListSubject.elements; import com.google.common.truth.FailureMetadata; import com.google.common.truth.StringSubject; import com.google.common.truth.Subject; +import com.google.gerrit.entities.LegacySubmitRequirement; import com.google.gerrit.entities.SubmitRecord; -import com.google.gerrit.entities.SubmitRequirement; import com.google.gerrit.truth.ListSubject; import com.google.gerrit.truth.OptionalSubject; import java.util.Optional; @@ -64,7 +64,8 @@ } /** Returns a {@link ListSubject} for the submit requirements. */ - public ListSubject<SubmitRequirementSubject, SubmitRequirement> hasSubmitRequirementsThat() { + public ListSubject<LegacySubmitRequirementSubject, LegacySubmitRequirement> + hasSubmitRequirementsThat() { return check("submitRequirements()") .about(elements()) .thatCustom(submitRecord().requirements, submitRecordRequirements());
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java index cf6e515..eb7e53f 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java
@@ -16,7 +16,7 @@ import static com.google.common.truth.Truth.assertThat; import static com.google.gerrit.plugins.codeowners.testing.CodeOwnerStatusInfoSubject.assertThat; -import static com.google.gerrit.plugins.codeowners.testing.SubmitRequirementInfoSubject.assertThatCollection; +import static com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementInfoSubject.assertThatCollection; import static com.google.gerrit.testing.GerritJUnit.assertThrows; import com.google.common.collect.ImmutableList; @@ -39,7 +39,7 @@ import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersIT; import com.google.gerrit.plugins.codeowners.api.CodeOwnerStatusInfo; import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; -import com.google.gerrit.plugins.codeowners.testing.SubmitRequirementInfoSubject; +import com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementInfoSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath; import com.google.inject.Inject; import org.eclipse.jgit.lib.ObjectId; @@ -119,7 +119,7 @@ assertThat(changeInfo.submittable).isFalse(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("NOT_READY"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -172,7 +172,7 @@ assertThat(changeInfo.submittable).isFalse(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("NOT_READY"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -222,7 +222,7 @@ assertThat(changeInfo.submittable).isTrue(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("OK"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -262,7 +262,7 @@ approve(changeId); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(gApi.changes().id(changeId).get().requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("OK"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -299,7 +299,7 @@ assertThat(changeInfo.submittable).isFalse(); // Check that the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("NOT_READY"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -342,7 +342,7 @@ .isTrue(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("OK"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -487,7 +487,7 @@ .isTrue(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("OK"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners");
diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/batch/CodeOwnerSubmitRuleBatchIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/batch/CodeOwnerSubmitRuleBatchIT.java index 9a06ccb..4235792 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/batch/CodeOwnerSubmitRuleBatchIT.java +++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/batch/CodeOwnerSubmitRuleBatchIT.java
@@ -2,7 +2,7 @@ import static com.google.common.truth.Truth.assertThat; import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.allowLabel; -import static com.google.gerrit.plugins.codeowners.testing.SubmitRequirementInfoSubject.assertThatCollection; +import static com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementInfoSubject.assertThatCollection; import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS; import com.google.gerrit.acceptance.LightweightPluginDaemonTest; @@ -13,7 +13,7 @@ import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations; import com.google.gerrit.extensions.client.ListChangesOption; import com.google.gerrit.extensions.common.ChangeInfo; -import com.google.gerrit.plugins.codeowners.testing.SubmitRequirementInfoSubject; +import com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementInfoSubject; import com.google.inject.Inject; import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; @@ -54,7 +54,7 @@ assertThat(changeInfo.submittable).isFalse(); // Check the submit requirement. - SubmitRequirementInfoSubject submitRequirementInfoSubject = + LegacySubmitRequirementInfoSubject submitRequirementInfoSubject = assertThatCollection(changeInfo.requirements).onlyElement(); submitRequirementInfoSubject.hasStatusThat().isEqualTo("NOT_READY"); submitRequirementInfoSubject.hasFallbackTextThat().isEqualTo("Code Owners");
diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRuleTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRuleTest.java index e493e40..8c18b66 100644 --- a/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRuleTest.java +++ b/javatests/com/google/gerrit/plugins/codeowners/backend/CodeOwnerSubmitRuleTest.java
@@ -27,8 +27,8 @@ import com.google.gerrit.entities.Change; import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; import com.google.gerrit.plugins.codeowners.acceptance.testsuite.CodeOwnerConfigOperations; +import com.google.gerrit.plugins.codeowners.testing.LegacySubmitRequirementSubject; import com.google.gerrit.plugins.codeowners.testing.SubmitRecordSubject; -import com.google.gerrit.plugins.codeowners.testing.SubmitRequirementSubject; import com.google.gerrit.plugins.codeowners.util.JgitPath; import com.google.gerrit.server.query.change.ChangeData; import com.google.inject.Inject; @@ -89,7 +89,7 @@ SubmitRecordSubject submitRecordSubject = assertThatOptional(codeOwnerSubmitRule.evaluate(changeData)).value(); submitRecordSubject.hasStatusThat().isNotReady(); - SubmitRequirementSubject submitRequirementSubject = + LegacySubmitRequirementSubject submitRequirementSubject = submitRecordSubject.hasSubmitRequirementsThat().onlyElement(); submitRequirementSubject.hasTypeThat().isEqualTo("code-owners"); submitRequirementSubject.hasFallbackTextThat().isEqualTo("Code Owners"); @@ -115,7 +115,7 @@ SubmitRecordSubject submitRecordSubject = assertThatOptional(codeOwnerSubmitRule.evaluate(changeData)).value(); submitRecordSubject.hasStatusThat().isOk(); - SubmitRequirementSubject submitRequirementSubject = + LegacySubmitRequirementSubject submitRequirementSubject = submitRecordSubject.hasSubmitRequirementsThat().onlyElement(); submitRequirementSubject.hasTypeThat().isEqualTo("code-owners"); submitRequirementSubject.hasFallbackTextThat().isEqualTo("Code Owners");