commit 331e6bdcb05641e32909a59d4610f4f5fd28bf34
author Edwin Kempin <ekempin@google.com> Thu Mar 04 10:19:23 2021 +0100
committer Edwin Kempin <ekempin@google.com> Thu Mar 04 10:19:23 2021 +0100
tree f96e4d01965d60a97c63f23ea003a11ba2f067f1
parent 9d55a2dafa8fc3d97eedd04dceb9c0b7f23317cc

CodeOwnerApprovalCheck: Remove unused changeNotes parameters

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ibe98f61e3a234010c0e62326be78d44c63875535

java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java

diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java
index 897131a..4c41510 100644
--- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java
+++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnerApprovalCheck.java
@@ -256,7 +256,7 @@
 
       ImmutableSet<RequiredApproval> overrideApprovals = codeOwnersConfig.getOverrideApproval();
       boolean hasOverride =
-          hasOverride(currentPatchSetApprovals, overrideApprovals, changeNotes, patchSetUploader);
+          hasOverride(currentPatchSetApprovals, overrideApprovals, patchSetUploader);
       logger.atFine().log(
           "hasOverride = %s (overrideApprovals = %s)",
           hasOverride,
@@ -282,8 +282,7 @@
       ImmutableSet<Account.Id> reviewerAccountIds =
           getReviewerAccountIds(requiredApproval, changeNotes, patchSetUploader);
       ImmutableSet<Account.Id> approverAccountIds =
-          getApproverAccountIds(
-              currentPatchSetApprovals, requiredApproval, changeNotes, patchSetUploader);
+          getApproverAccountIds(currentPatchSetApprovals, requiredApproval, patchSetUploader);
       logger.atFine().log("reviewers = %s, approvers = %s", reviewerAccountIds, approverAccountIds);
 
       FallbackCodeOwners fallbackCodeOwners = codeOwnersConfig.getFallbackCodeOwners();
@@ -885,12 +884,10 @@
    *
    * @param requiredApproval approval that is required from code owners to approve the files in a
    *     change
-   * @param changeNotes the change notes
    */
   private ImmutableSet<Account.Id> getApproverAccountIds(
       ImmutableList<PatchSetApproval> currentPatchSetApprovals,
       RequiredApproval requiredApproval,
-      ChangeNotes changeNotes,
       Account.Id patchSetUploader) {
     ImmutableSet<Account.Id> approverAccountIds =
         currentPatchSetApprovals.stream()
@@ -932,14 +929,12 @@
    * Checks whether the given change has an override approval.
    *
    * @param overrideApprovals approvals that count as override for the code owners submit check.
-   * @param changeNotes the change notes
    * @param patchSetUploader account ID of the patch set uploader
    * @return whether the given change has an override approval
    */
   private boolean hasOverride(
       ImmutableList<PatchSetApproval> currentPatchSetApprovals,
       ImmutableSet<RequiredApproval> overrideApprovals,
-      ChangeNotes changeNotes,
       Account.Id patchSetUploader) {
     ImmutableSet<RequiredApproval> overrideApprovalsThatIgnoreSelfApprovals =
         overrideApprovals.stream()