commit 329839984231cb6a17dd0af278f7f9153d3a9809
author Edwin Kempin <ekempin@google.com> Fri Apr 09 12:48:19 2021 +0200
committer Edwin Kempin <ekempin@google.com> Mon Apr 12 11:05:51 2021 +0200
tree 14bdc21659d39389974d123aed7fd61daf61f347
parent 2ea2452beb9162b34c78a85d9a0cdb2935e9ab43

Fix names of code owner metrics

Gerrit automatically prefixes plugin metrics with
"plugins/<plugin-name>/". This means the "code_owners/" prefix that we
add for code owner metrics is redundant, e.g. at the moment metric names
look like this:

  plugins/code-owners/code_owners/count_code_owner_submit_rule_runs

Drop the "code_owners/" prefix so that metric names now look like this:

  plugins/code-owners/count_code_owner_submit_rule_runs

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ic3486a23f6d6afe729f0000977411a4f4b361340

java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java

diff --git a/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java b/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
index 26b81c8..8660d5c 100644
--- a/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
+++ b/java/com/google/gerrit/plugins/codeowners/metrics/CodeOwnerMetrics.java
@@ -175,8 +175,7 @@
 
   private Timer0 createLatencyTimer(String name, String description) {
     return metricMaker.newTimer(
-        "code_owners/" + name,
-        new Description(description).setCumulative().setUnit(Units.MILLISECONDS));
+        name, new Description(description).setCumulative().setUnit(Units.MILLISECONDS));
   }
 
   private Timer1<String> createTimerWithClassField(
@@ -187,23 +186,22 @@
             .build();
 
     return metricMaker.newTimer(
-        "code_owners/" + name,
+        name,
         new Description(description).setCumulative().setUnit(Description.Units.MILLISECONDS),
         CODE_OWNER_BACKEND_FIELD);
   }
 
   private Counter0 createCounter(String name, String description) {
-    return metricMaker.newCounter("code_owners/" + name, new Description(description).setRate());
+    return metricMaker.newCounter(name, new Description(description).setRate());
   }
 
   private <F1, F2, F3> Counter3<F1, F2, F3> createCounter3(
       String name, String description, Field<F1> field1, Field<F2> field2, Field<F3> field3) {
     return metricMaker.newCounter(
-        "code_owners/" + name, new Description(description).setRate(), field1, field2, field3);
+        name, new Description(description).setRate(), field1, field2, field3);
   }
 
   private Histogram0 createHistogram(String name, String description) {
-    return metricMaker.newHistogram(
-        "code_owners/" + name, new Description(description).setCumulative());
+    return metricMaker.newHistogram(name, new Description(description).setCumulative());
   }
 }