Drop tests for creating changes on checker refs
Since change If5fb50e1f the Create Change REST endpoint no longer allows
to create changes on NoteDb refs. Drop the tests as this is non-critical
functionality for the checks plugin and also the checks plugin is
discontinued.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I6d7ee35e9a94cd7a4584d5fe764d50408e19eb73
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/CheckerRefsIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/CheckerRefsIT.java
index abb015a..df918fa 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/CheckerRefsIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/CheckerRefsIT.java
@@ -30,7 +30,6 @@
import com.google.gerrit.entities.Permission;
import com.google.gerrit.entities.Project;
import com.google.gerrit.extensions.client.ChangeStatus;
-import com.google.gerrit.extensions.common.ChangeInput;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.plugins.checks.CheckerRef;
import com.google.gerrit.plugins.checks.CheckerUuid;
@@ -305,52 +304,6 @@
r.assertOkStatus();
}
- @Test
- public void createChangeForCheckerRefsViaApiIsDisabled() throws Exception {
- CheckerUuid checkerUuid = checkerOperations.newChecker().create();
- String checkerRef = checkerUuid.toRefName();
-
- TestRepository<InMemoryRepository> repo = cloneProject(allProjects, admin);
- fetch(repo, checkerRef + ":checkerRef");
- repo.reset("checkerRef");
- RevCommit head = getHead(repo.getRepository(), "HEAD");
-
- ChangeInput input = new ChangeInput();
- input.project = allProjects.get();
- input.branch = checkerRef;
- input.baseCommit = head.name();
- input.subject = "A change.";
-
- ResourceConflictException thrown =
- assertThrows(ResourceConflictException.class, () -> gApi.changes().create(input));
- assertThat(thrown).hasMessageThat().contains("creating change for checker ref not allowed");
- }
-
- @Test
- public void createChangeForCheckerLikeRefViaApi() throws Exception {
- String checkerRef = CheckerUuid.parse("foo:bar").toRefName();
-
- projectOperations
- .project(project)
- .forUpdate()
- .add(allow(Permission.CREATE).ref(checkerRef).group(adminGroupUuid()))
- .update();
- createBranch(BranchNameKey.create(project, checkerRef));
-
- TestRepository<InMemoryRepository> repo = cloneProject(project, admin);
- fetch(repo, checkerRef + ":checkerRef");
- repo.reset("checkerRef");
- RevCommit head = getHead(repo.getRepository(), "HEAD");
-
- // creating a change on a checker ref via API should work in any project except All-Projects
- ChangeInput input = new ChangeInput();
- input.project = project.get();
- input.branch = checkerRef;
- input.baseCommit = head.name();
- input.subject = "A change.";
- assertThat(gApi.changes().create(input).get()).isNotNull();
- }
-
private String createChangeWithoutCommitValidation(Project.NameKey project, String targetRef)
throws Exception {
try (Repository git = repoManager.openRepository(project);
