| commit | da20fd6ba2a0845273c921eeed0275a0b0b8ea4b | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Oct 09 15:33:58 2019 +0200 |
| committer | David Pursehouse <dpursehouse@collab.net> | Thu Oct 10 09:48:45 2019 +0900 |
| tree | 7cd397e84835aef6169aca06f3aa48141b762a1d | |
| parent | 0a21cd2ddb432b32fbcf10f8e0decfda5021de4f [diff] |
Notify only owner if combined check state is updated to non-passing state Reviewers are only interested in the combined check state when it turns to a value that makes the change submittable. This is the case for the states SUCCESSFUL and NOT_RELEVANT. Other combined check states are only relevant for the change owner, hence for those an email notification should only be sent to the change owner. This is just the default for the notifications. Callers can always override it by setting NotifyHandling in the REST input. Rerunning a check cannot cause an update of the combined check state to SUCCESSFUL or NOT_RELEVANT, hence there is no test and documentation for this case Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I37d407d3336f42d5cd876cccd90ee115cf7fe41d
This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.
This plugin uses polymer-cli to test.
After bower install, running polymer test -l chrome will run all tests in Chrome, and running polymer serve and navigating to http://127.0.0.1:8081/components/checks/gr-checks/gr-checks-view_test.html allows for manual debugging.