commit d13c43f30374c61451e34eaaae13441f66e5d33e
author Edwin Kempin <ekempin@google.com> Wed Mar 27 13:54:03 2019 +0100
committer Edwin Kempin <ekempin@google.com> Wed Mar 27 15:54:15 2019 +0100
tree 908f4cb3f9bfd9c72c2eda7d00cc6d24bff01584
parent c7ffd8ea1189df35d15893b2c122db5d9e92bc21

ListChecksIT: Rename 'info' veriables to 'checks'

'info' sounds like it's a single CheckInfo entity, but in fact it's a
collection of checks.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Iff21f486111bbe5b47443e575abeadeaf262221f

javatests/com/google/gerrit/plugins/checks/acceptance/api/ListChecksIT.java

diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/ListChecksIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/ListChecksIT.java
index 9f55fa2..c7348ba 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/ListChecksIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/ListChecksIT.java
@@ -57,7 +57,7 @@
 
   @Test
   public void listAll() throws Exception {
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
 
     CheckInfo expected1 = new CheckInfo();
     expected1.project = checkKey1.project().get();
@@ -77,12 +77,12 @@
     expected2.created = checkOperations.check(checkKey2).get().created();
     expected2.updated = expected2.created;
 
-    assertThat(info).containsExactly(expected1, expected2);
+    assertThat(checks).containsExactly(expected1, expected2);
   }
 
   @Test
   public void listAllWithOptions() throws Exception {
-    Collection<CheckInfo> info =
+    Collection<CheckInfo> checks =
         checksApiFactory.revision(patchSetId).list(ListChecksOption.CHECKER);
 
     CheckInfo expected1 = new CheckInfo();
@@ -108,7 +108,7 @@
     expected2.blocking = ImmutableSet.of();
     expected2.checkerStatus = CheckerStatus.ENABLED;
 
-    assertThat(info).containsExactly(expected1, expected2);
+    assertThat(checks).containsExactly(expected1, expected2);
   }
 
   @Test
@@ -120,8 +120,8 @@
         .repository(otherProject)
         .update();
 
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
-    assertThat(info)
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
+    assertThat(checks)
         .containsExactly(
             checkOperations.check(checkKey1).asInfo(), checkOperations.check(checkKey2).asInfo());
   }
@@ -134,8 +134,8 @@
         .query("message:not-matching")
         .update();
 
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
-    assertThat(info)
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
+    assertThat(checks)
         .containsExactly(
             checkOperations.check(checkKey1).asInfo(), checkOperations.check(checkKey2).asInfo());
   }
@@ -144,8 +144,8 @@
   public void listIncludesCheckFromDisabledChecker() throws Exception {
     checkerOperations.checker(checkKey2.checkerUuid()).forUpdate().disable().update();
 
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
-    assertThat(info)
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
+    assertThat(checks)
         .containsExactly(
             checkOperations.check(checkKey1).asInfo(), checkOperations.check(checkKey2).asInfo());
   }
@@ -154,8 +154,8 @@
   public void listIncludesCheckFromInvalidChecker() throws Exception {
     checkerOperations.checker(checkKey2.checkerUuid()).forUpdate().forceInvalidConfig().update();
 
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
-    assertThat(info)
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
+    assertThat(checks)
         .containsExactly(
             checkOperations.check(checkKey1).asInfo(), checkOperations.check(checkKey2).asInfo());
   }
@@ -164,8 +164,8 @@
   public void listIncludesCheckFromNonExistingChecker() throws Exception {
     checkerOperations.checker(checkKey2.checkerUuid()).forUpdate().deleteRef().update();
 
-    Collection<CheckInfo> info = checksApiFactory.revision(patchSetId).list();
-    assertThat(info)
+    Collection<CheckInfo> checks = checksApiFactory.revision(patchSetId).list();
+    assertThat(checks)
         .containsExactly(
             checkOperations.check(checkKey1).asInfo(), checkOperations.check(checkKey2).asInfo());
   }