Google Git
Sign in
gerrit / plugins / checks / d989667ca8c16a34e0513922a8dcd97c25c7d38f
commitd989667ca8c16a34e0513922a8dcd97c25c7d38f[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Tue Mar 26 09:21:50 2019 +0100
committerEdwin Kempin <ekempin@google.com>Wed Mar 27 15:59:00 2019 +0100
tree5bc050dea1d6ea0b82578e152afa6f59e5f546a7
parentdc75cfa0006be78da24ec2a9d620e277769d4252 [diff]
CheckerConfig#getConfigForTesting: Return Optional<Config>

The config is only available after load, and only if the checker ref
already exists. This means the returned config could have been null, but
the method was not annotated with @Nullable and callers were not
checking for null. To make this method safer to use and more consistent
with other methods in CheckerConfig return Optional<Config>.

Also rename the 'config' member variable to 'loadedConfig' to make the
naming consistent with the 'loadedChecker' member variable.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I729931525fe789177f6a2548b121569d3e94e29c
3 files changed
tree: 5bc050dea1d6ea0b82578e152afa6f59e5f546a7
  1. java/
  2. javatests/
  3. src/
  4. BUILD
  5. LICENSE
  6. README.md
README.md

Gerrit Code Review Checks Plugin

This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.