| commit | b7f74520c14c9ec282d7a06e022159b417b40d73 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Mon Dec 13 13:12:24 2021 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Mon Dec 13 13:13:46 2021 +0100 |
| tree | f06af7cd6d175777c76f5a96c0f2c54318f10b82 | |
| parent | ea23fefec2584c8eacaeb613b2a02170f8de930d [diff] |
CheckSubmitRule: Return Optional#empty() if all checkers are optional If all configured checkers for a project are optional, it's better to return an Optional#empty() instead of a record with status=OK. This is also needed by submit requirements, since we convert results of legacy submit rules to submit requirements. If we return an Optional#empty(), the SR evaluator will just skip creating a submit requirement result for it. Google-Bug-Id: b/209752314 Change-Id: Ia96861ed4bd5b4644f79988e3a7a8d221d42a227
The Gerrit team at Google has decided to discontinue work on the checks plugin. The recommended solution is [https://gerrit-review.googlesource.com/Documentation/pg-plugin-checks-api.html](Checks UI) which surfaces results from an external CI/analysis system.
This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.
When upgrading the plugin, please use init:
java -jar gerrit.war init -d site_path
More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html
To enable sending email notifications for “checks” status updates, you'll need to create the email templates in <your-site-path>/etc/mail. In the simplest form, simply rename the example templates:
cd "<your-site-path>"
mv etc/mail/CombinedCheckStateUpdated.soy{.example,}
mv etc/mail/CombinedCheckStateUpdatedHtml.soy{.example,}
For running unit tests execute:
bazel test --test_output=all //plugins/checks/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/checks/web:lint_test bazel run //plugins/checks/web:lint_bin -- --fix "$(pwd)/plugins/checks/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/ folder:
bazel build //plugins/checks/web:checks cp -f bazel-bin/plugins/checks/web/checks.js plugins/
and let the Dev Helper redirect from .+/plugins/checks/static/checks.js to http://localhost:8081/plugins_/checks.js.