Google Git
Sign in
gerrit / plugins / checks / b21b178e6a2643e2d6d260952a66be67514392ee
commitb21b178e6a2643e2d6d260952a66be67514392ee[log] [tgz]
authorSven Selberg <svense@axis.com>Mon Jun 15 10:05:24 2020 +0200
committerSven Selberg <svense@axis.com>Mon Jun 15 10:08:42 2020 +0200
tree329bcf70cc18867eb70aa7dd8d52cbfdba788de9
parent50848a3e3af7fe457013bc5f2fdec0b1b519d535 [diff]
Doc: Change CheckInput example to valid JSON

JSON does not allow trailing commas.
When using the current example you get:
"Invalid application/json in request"

Change-Id: Iff346918f453ff6bd5c47a0494046b45872e1fb1
1 file changed
tree: 329bcf70cc18867eb70aa7dd8d52cbfdba788de9
  1. gr-checks/
  2. java/
  3. javatests/
  4. proto/
  5. resources/
  6. test/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review Checks Plugin

This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.

When upgrading the plugin, please use init:

java -jar gerrit.war init -d site_path

More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html

UI tests

To run UI tests here will need install dependencies from both npm and bower.

npm run wct-test should take care both for you, read more in package.json.

You will need polymer-bridges which is a submodule you can clone from: https://gerrit-review.googlesource.com/admin/repos/polymer-bridges

Test plugin on Gerrit

  1. Build the bundle locally with: bazel build gr-checks:gr-checks
  2. Serve your generated ‘checks.js’ somewhere, you can put it under gerrit/plugins/checks/ folder and it will automatically served at http://localhost:8081/plugins_/checks/ (no need to pass it to --plugins flag)
  3. Use FE dev helper, https://gerrit.googlesource.com/gerrit-fe-dev-helper/, inject the local served ‘checks.js’ to the page

If your plugin is already enabled, then you can block it and then inject the compiled local verison.

See more about how to use dev helper extension to help you test here: https://gerrit.googlesource.com/gerrit-fe-dev-helper/+/master