commit 9c5f7b3bb4933aaf51c3e0e76f5f237f75604e24
author Alice Kober-Sotzek <aliceks@google.com> Thu Mar 14 11:59:05 2019 +0100
committer Alice Kober-Sotzek <aliceks@google.com> Thu Mar 14 14:31:26 2019 +0100
tree 3e1ebdd3bc831dcc468b336f08a0915f176437df
parent 7ecd81468baf96ed0a6f761bdc311d36057d55b3

Ensure check data is deleted when change is deleted

We are lucky that when a change is deleted, all refs starting with
refs/changes/<sharded-change-id> are removed. Since we use that prefix
for the refs of the checks, we don't have to implement anything
additionally.

To ensure that unrelated changes in core Gerrit do not silently break
the check data deletion, add a test for it.

The existing Java API for checks didn't behave well when the change was
deleted. Correct that and also test it.

Change-Id: I40187d964a302bfd0112c7f02f698d0b7d51fb67