Google Git
Sign in
gerrit / plugins / checks / 72bf49fef32f805d972ad316aebf527306ed3f8e
commit72bf49fef32f805d972ad316aebf527306ed3f8e[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Wed Mar 03 13:03:11 2021 +0100
committerBen Rohlfs <brohlfs@google.com>Wed Mar 03 13:03:11 2021 +0100
treec608f48ec9fa280ecf6c475e610442c5828bfc8c
parent36bcf90eb66ae37a0f7d145d1299908baa0f9794 [diff]
Fix generateDurationString()

It would show `1 1 hour 5 min` instead of `1 hour 5 min`.

Change-Id: Ie2fa80dca80b9a71c98d6dd2eaec4397939e5b59
1 file changed
tree: c608f48ec9fa280ecf6c475e610442c5828bfc8c
  1. gr-checks/
  2. java/
  3. javatests/
  4. proto/
  5. resources/
  6. test/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review Checks Plugin

This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.

When upgrading the plugin, please use init:

java -jar gerrit.war init -d site_path

More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html

UI tests

To run UI tests here will need install dependencies from both npm and bower.

npm run wct-test should take care both for you, read more in package.json.

You will need polymer-bridges which is a submodule you can clone from: https://gerrit-review.googlesource.com/admin/repos/polymer-bridges

Test plugin on Gerrit

  1. Build the bundle locally with: bazel build gr-checks:gr-checks
  2. Serve your generated ‘checks.js’ somewhere, you can put it under gerrit/plugins/checks/ folder and it will automatically served at http://localhost:8081/plugins_/checks/ (no need to pass it to --plugins flag)
  3. Use FE dev helper, https://gerrit.googlesource.com/gerrit-fe-dev-helper/, inject the local served ‘checks.js’ to the page

If your plugin is already enabled, then you can block it and then inject the compiled local verison.

See more about how to use dev helper extension to help you test here: https://gerrit.googlesource.com/gerrit-fe-dev-helper/+/master