Google Git
Sign in
gerrit / plugins / checks / 63101973b30f8171cb55297db3f4299cd9593abb
commit63101973b30f8171cb55297db3f4299cd9593abb[log] [tgz]
authorSven Selberg <svense@axis.com>Thu Jun 25 14:10:20 2020 +0200
committerDavid Ostrovsky <david.ostrovsky@gmail.com>Thu Jun 25 19:25:14 2020 +0000
treedf319984f71e6abfb1c11f9d2b30a6640013f055
parent80ce21ea9b693ac21c57d30a912c6bd20bd195ae [diff]
Fix broken CheckerRefMigrationTest

In [1] injection of AllProjects was replaced with an injection of
AllProjectsNameOnInitProvider since AllProjects was not available on
init.
The fact that the CheckerRefMigrationTest used that constructor was
missed which caused the tests to fail.

Keep the Project.NameKey of All-Projects as member and overload the
constructor so that tests can supply a test controlled Project.NameKey.

[1] 75e72bd - CheckerRefMigration: Use AllProjectsNameOnInitProvider

Bug: Issue 13005
Bug: Issue 12904
Change-Id: I1448c496b3613a07f7d51cba1b46d012c1506d3d
1 file changed
tree: df319984f71e6abfb1c11f9d2b30a6640013f055
  1. gr-checks/
  2. java/
  3. javatests/
  4. proto/
  5. resources/
  6. test/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review Checks Plugin

This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.

When upgrading the plugin, please use init:

java -jar gerrit.war init -d site_path

More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html

UI tests

To run UI tests here will need install dependencies from both npm and bower.

npm run wct-test should take care both for you, read more in package.json.

You will need polymer-bridges which is a submodule you can clone from: https://gerrit-review.googlesource.com/admin/repos/polymer-bridges

Test plugin on Gerrit

  1. Build the bundle locally with: bazel build gr-checks:gr-checks
  2. Serve your generated ‘checks.js’ somewhere, you can put it under gerrit/plugins/checks/ folder and it will automatically served at http://localhost:8081/plugins_/checks/ (no need to pass it to --plugins flag)
  3. Use FE dev helper, https://gerrit.googlesource.com/gerrit-fe-dev-helper/, inject the local served ‘checks.js’ to the page

If your plugin is already enabled, then you can block it and then inject the compiled local verison.

See more about how to use dev helper extension to help you test here: https://gerrit.googlesource.com/gerrit-fe-dev-helper/+/master