commit | 4bf1f12d6a06389277b3ba6226d8e68a8e13c129 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Tue Jul 23 13:26:38 2019 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Wed Jul 24 15:19:50 2019 +0200 |
tree | c1b2fd29b2f8ee0e60965e9c1517d8d6bd587cbf | |
parent | 2ec8599f230018471b044c2e0024428f04e7fc4b [diff] |
Make name of checker mandatory So far it was possible to create checkers without name, but unsetting a name of an existing checker was not allowed. Make this consistent and require a name also on checker creation. The documentation already claimed that it was mandatory. The same as for all other mandatory checker properties, a missing name makes a checker invalid and it cannot be accessed through the API. This means existing checkers without name have to be fixed manually to work after this change. This is OK since the checks plugin is not widely used yet. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I08822edb6d068d750b3905bc02e01d44914dfc94
This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.
This plugin uses polymer-cli to test.
After bower install
, running polymer test -l chrome
will run all tests in Chrome, and running polymer serve
and navigating to http://127.0.0.1:8081/components/checks/gr-checks/gr-checks-view_test.html allows for manual debugging.