commit | 31d8e0cc535de530650565281e17c89bd0d35bff | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jun 14 08:02:47 2024 +0000 |
committer | Edwin Kempin <ekempin@google.com> | Fri Jun 14 08:02:47 2024 +0000 |
tree | 802f8edc9d9132eedbcbfd0edd010f751cb1f9ec | |
parent | 7f1a25d443ddbae2e6b6523bcc1ee03b8b349c6e [diff] |
Migrate usages of `and`/`or` to `&&`/`||`. This change has been applied internally at Google and importing the checks plugin overrides this change now, which causes test failures. Apply this fix in upstream to fix this. Change-Id: Ic7346a0f54a311dfb67bd5b44f758aeb1838c238 Signed-off-by: Edwin Kempin <ekempin@google.com>
The Gerrit team at Google has decided to discontinue work on the checks plugin. The recommended solution is [https://gerrit-review.googlesource.com/Documentation/pg-plugin-checks-api.html](Checks UI) which surfaces results from an external CI/analysis system.
This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.
When upgrading the plugin, please use init:
java -jar gerrit.war init -d site_path
More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html
To enable sending email notifications for “checks” status updates, you'll need to create the email templates in <your-site-path>/etc/mail
. In the simplest form, simply rename the example templates:
cd "<your-site-path>" mv etc/mail/CombinedCheckStateUpdated.soy{.example,} mv etc/mail/CombinedCheckStateUpdatedHtml.soy{.example,}
For running unit tests execute:
bazel test --test_output=all //plugins/checks/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/checks/web:lint_test bazel run //plugins/checks/web:lint_bin -- --fix "$(pwd)/plugins/checks/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/
folder:
bazel build //plugins/checks/web:checks cp -f bazel-bin/plugins/checks/web/checks.js plugins/
and let the Dev Helper redirect from .+/plugins/checks/static/checks.js
to http://localhost:8081/plugins_/checks.js
.