commit | 2d34f115f09aee14b582929f0b21766622e2c671 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Thu Jun 23 17:07:43 2022 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Thu Jun 23 17:07:43 2022 +0200 |
tree | 9f68d809066bfdd917ee2e33628bba6f5fde3468 | |
parent | c948aead3bfae0e15dce683ac23d42fb5d2b1d69 [diff] |
Fix duration string `getMilliseconds()` does not do what we thought is was doing. It does not return the milliseconds since the epoch, but just a value between 0 and 999. Fixing this and adding tests. Release-Notes: skip Google-Bug-Id: b/216743635 Change-Id: I74b5ab5d412e31f1cdc759e371e86ca9f62079be
The Gerrit team at Google has decided to discontinue work on the checks plugin. The recommended solution is [https://gerrit-review.googlesource.com/Documentation/pg-plugin-checks-api.html](Checks UI) which surfaces results from an external CI/analysis system.
This plugin provides a unified experience for checkers (CI systems, static analyzers, etc.) to integrate with Gerrit Code Review.
When upgrading the plugin, please use init:
java -jar gerrit.war init -d site_path
More details about “init” in https://gerrit-review.googlesource.com/Documentation/pgm-init.html
To enable sending email notifications for “checks” status updates, you'll need to create the email templates in <your-site-path>/etc/mail
. In the simplest form, simply rename the example templates:
cd "<your-site-path>" mv etc/mail/CombinedCheckStateUpdated.soy{.example,} mv etc/mail/CombinedCheckStateUpdatedHtml.soy{.example,}
For running unit tests execute:
bazel test --test_output=all //plugins/checks/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/checks/web:lint_test bazel run //plugins/checks/web:lint_bin -- --fix "$(pwd)/plugins/checks/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/
folder:
bazel build //plugins/checks/web:checks cp -f bazel-bin/plugins/checks/web/checks.js plugins/
and let the Dev Helper redirect from .+/plugins/checks/static/checks.js
to http://localhost:8081/plugins_/checks.js
.