Put variable declaration closer to use Gets rid of a call and better defines its scope. Change-Id: I28e6b8acb0f8b9e13cbfa049419e94072c6883a6 Signed-off-by: Patrick Georgi <pgeorgi@google.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java index c4c2192..f85ca97 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java +++ b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
@@ -67,7 +67,6 @@ if (ssl && externalAvatarUrl.startsWith("http://")) { externalAvatarUrl = externalAvatarUrl.replace("http://", "https://"); } - StringBuilder avatarUrl = new StringBuilder(); String userReplacedAvatarURL = fillOutTemplate(externalAvatarUrl, forUser); @@ -81,7 +80,7 @@ return null; } - avatarUrl.append(userReplacedAvatarURL); + StringBuilder avatarUrl = new StringBuilder(userReplacedAvatarURL); if (imageSize > 0 && sizeParameter != null) { if (avatarUrl.indexOf("?") < 0) { avatarUrl.append("?");