commit | b54d8cdb1f2b864ecfbfc29a6b2da2014dc1d0ca | [log] [tgz] |
---|---|---|
author | Patrick Georgi <pgeorgi@google.com> | Tue Sep 24 14:33:15 2019 +0200 |
committer | Patrick Georgi <pgeorgi@google.com> | Tue Sep 24 14:35:33 2019 +0200 |
tree | d7f88e469a50fcca0d3fd3b9c4dcfb9b7f094649 | |
parent | 63c16b4afe62c0fe1c93502fc5135bed731689e9 [diff] |
Put variable declaration closer to use Gets rid of a call and better defines its scope. Change-Id: I28e6b8acb0f8b9e13cbfa049419e94072c6883a6 Signed-off-by: Patrick Georgi <pgeorgi@google.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java index c4c2192..f85ca97 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java +++ b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
@@ -67,7 +67,6 @@ if (ssl && externalAvatarUrl.startsWith("http://")) { externalAvatarUrl = externalAvatarUrl.replace("http://", "https://"); } - StringBuilder avatarUrl = new StringBuilder(); String userReplacedAvatarURL = fillOutTemplate(externalAvatarUrl, forUser); @@ -81,7 +80,7 @@ return null; } - avatarUrl.append(userReplacedAvatarURL); + StringBuilder avatarUrl = new StringBuilder(userReplacedAvatarURL); if (imageSize > 0 && sizeParameter != null) { if (avatarUrl.indexOf("?") < 0) { avatarUrl.append("?");