commit b9bab3a0c4c36de55824c8544baad33e5c5c324c
author Chris Poucet <poucet@google.com> Tue Oct 12 18:23:04 2021 +0200
committer Chris Poucet <poucet@google.com> Tue Oct 12 18:23:04 2021 +0200
tree 934e7e9ce085a5cf8256155c3bb7abef39f98add
parent 5e4c7d80d5ad7d2573f22b9190c174a4293e6cca

Get rid of usage of private _getElement from automerger.

Change-Id: Ibe463e7593ee971844bc5cb4486b26e99d6ef3ad

web/automerger.ts

diff --git a/web/automerger.ts b/web/automerger.ts
index 96bcab5..cb0f499 100644
--- a/web/automerger.ts
+++ b/web/automerger.ts
@@ -32,11 +32,6 @@
   __url?: string;
 }
 
-export interface PopupPluginApiExtended extends PopupPluginApi {
-  // TODO: Remove this reference to a private method. This can break any time.
-  _getElement: () => HTMLElement;
-}
-
 export class Automerger {
   private change?: ChangeInfo;
 
@@ -94,9 +89,7 @@
     popupContent.appendChild(this.createMergeButton(branchToCheckbox));
 
     this.plugin.popup().then((popApi: PopupPluginApi) => {
-      const popupEl = (popApi as PopupPluginApiExtended)._getElement();
-      if (!popupEl) throw new Error('Popup element not found');
-      popupEl.appendChild(popupContent);
+      popup.appendContent(popupContent);
     });
   }