Format and style fixes.
Change-Id: If843628aa1e67f6b0945f0a0df1976a027106357
diff --git a/src/main/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreator.java b/src/main/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreator.java
index 9ca0f7a..02f5bc5 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreator.java
@@ -488,7 +488,7 @@
*/
private String getBaseChangeId(List<String> parents, String branch)
throws InvalidQueryParameterException, RestApiException {
- if (parents.size() == 0) {
+ if (parents.isEmpty()) {
log.info("No base change id for change with no parents.");
return null;
}
@@ -666,9 +666,9 @@
.query(queryBuilder.get())
.withOption(ListChangesOption.CURRENT_REVISION)
.get();
- if (changes.size() > 0) {
+ if (!changes.isEmpty()) {
for (ChangeInfo change : changes) {
- if (change.currentRevision.equals(revision) && change.topic != "") {
+ if (change.currentRevision.equals(revision) && !"".equals(change.topic)) {
return change.topic;
}
}
diff --git a/src/test/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreatorIT.java b/src/test/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreatorIT.java
index d3c2853..728ee7c 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreatorIT.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/automerger/DownstreamCreatorIT.java
@@ -27,7 +27,6 @@
import com.google.gerrit.extensions.common.ApprovalInfo;
import com.google.gerrit.extensions.common.ChangeInfo;
import com.google.gerrit.extensions.restapi.BinaryResult;
-import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.reviewdb.client.Branch;
import com.google.gerrit.reviewdb.client.Project;
