gerrit_plugin: Remove provided_deps from API

Bazel rejected the proposal to support a "provided_deps" (or
"compile_deps") attribute in java_library, so remove this attribute
from the gerrit_plugin API.

Keeping it would be misleading, as it suggests support for a concept
that Bazel does not provide. Other build systems, such as Buck, do
support this feature, which could further confuse users.

See the discussion in [1] for details.

[1] https://github.com/bazelbuild/bazel/issues/1402

Change-Id: I82bc541705ef8d596441bc13df0be18e9f404cf3

gerrit_plugin.bzl

diff --git a/gerrit_plugin.bzl b/gerrit_plugin.bzl
index a47fb78..8e655b3 100644
--- a/gerrit_plugin.bzl
+++ b/gerrit_plugin.bzl
@@ -101,7 +101,6 @@
         deps = [],
         ext_deps = [],
         ext_repo = None,
-        provided_deps = [],
         srcs = [],
         resources = [],
         resource_jars = [],
@@ -121,7 +120,6 @@
       ext_deps: List of Maven coordinates for external dependencies.
       ext_repo: Name of the external repository generated by rules_jvm_external.
         Defaults to `<name>_plugin_deps`.
-      provided_deps: List of dependencies that are provided by Gerrit and should not be bundled.
       srcs: List of Java source files for the plugin.
       resources: List of resource files to be included in the plugin JAR.
       resource_jars: List of JARs containing resources.
@@ -152,7 +150,7 @@
         name = name + "__plugin",
         srcs = srcs,
         resources = resources,
-        deps = provided_deps + deps + gerrit_api_neverlink(name),
+        deps = deps + gerrit_api_neverlink(name),
         runtime_deps = runtime_deps,
         visibility = ["//visibility:public"],
         **kwargs