build: add error checking to Finish calls in tests
Change-Id: Ief7dce9993a826a513b8543b15e19092f419fd1f
diff --git a/build/e2e_test.go b/build/e2e_test.go
index d6a7fe7..40de0a4 100644
--- a/build/e2e_test.go
+++ b/build/e2e_test.go
@@ -58,7 +58,9 @@
b.AddFile("F"+s, []byte(strings.Repeat(s, 1000)))
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
fs, _ := filepath.Glob(dir + "/*")
if len(fs) <= 1 {
@@ -117,7 +119,9 @@
b.AddFile("F"+s, []byte(strings.Repeat("a", sizeMax+1)))
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
ss, err := shards.NewDirectorySearcher(dir)
if err != nil {
@@ -163,7 +167,9 @@
t.Fatalf("NewBuilder: %v", err)
} else {
b.AddFile("F", []byte("hoi"))
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
}
ss, err := shards.NewDirectorySearcher(dir)
if err != nil {
@@ -194,7 +200,9 @@
t.Fatalf("NewBuilder: %v", err)
} else {
b.AddFile("F", []byte("hoi"))
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
}
// This is ugly, and potentially flaky, but there is no
@@ -255,7 +263,9 @@
s := fmt.Sprintf("%d\n", i)
b.AddFile("F"+s, []byte(strings.Repeat(s, 1024/2)))
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
glob := filepath.Join(dir, "*")
fs, err := filepath.Glob(glob)
@@ -282,7 +292,9 @@
s := fmt.Sprintf("%d\n", i)
b.AddFile("F"+s, []byte(strings.Repeat(s, 1024/2)))
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
fs, err = filepath.Glob(glob)
if err != nil {
@@ -296,7 +308,9 @@
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
fs, err = filepath.Glob(glob)
if err != nil {
@@ -342,8 +356,10 @@
t.Fatalf("chmod(%s, writable): %s", dir, err)
}
+ // No error checking.
b.Finish()
+ // Finish cleans up temporary files.
if fs, err := filepath.Glob(dir + "/*"); err != nil {
t.Errorf("glob(%s): %v", dir, err)
} else if len(fs) != 0 {
@@ -444,7 +460,9 @@
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
- b.Finish()
+ if err := b.Finish(); err != nil {
+ t.Errorf("Finish: %v", err)
+ }
fs, _ := filepath.Glob(dir + "/*")
if len(fs) != 1 {
