Reorder checks from cheap to expensive It makes sense to perform cheap checks at first, because if they already fail we don't waste computing time on more expensive checks. Change-Id: Iac508c190605132d4eecfa2e2a22d30435ecaaf4
diff --git a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/Module.java b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/Module.java index f63a707..a3cbfc4 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/Module.java +++ b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/Module.java
@@ -22,15 +22,16 @@ protected void configure() { install(new PatternCacheModule()); install(ContentTypeUtil.module()); - install(BlockedKeywordValidator.module()); - install(DuplicatePathnameValidator.module()); - install(FileExtensionValidator.module()); + install(FooterValidator.module()); - install(InvalidFilenameValidator.module()); - install(InvalidLineEndingValidator.module()); install(MaxPathLengthValidator.module()); - install(ContentTypeValidator.module()); + install(FileExtensionValidator.module()); + install(InvalidFilenameValidator.module()); install(SubmoduleValidator.module()); install(SymlinkValidator.module()); + install(BlockedKeywordValidator.module()); + install(InvalidLineEndingValidator.module()); + install(ContentTypeValidator.module()); + install(DuplicatePathnameValidator.module()); } }