ChangeEmailValidator: add more sophisticated test cases This does not do any functional change to the uploadvalidator, but adds testcases of interest. Such are rejecting a certain username pattern from a domain, while still allowing the domain. Bug: 259663353 Change-Id: I29b8b00292a017d3acad557121d01d8f9a6ac54f Signed-off-by: Matthias Maennich <maennich@google.com>
diff --git a/src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/ChangeEmailTest.java b/src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/ChangeEmailTest.java index 2c83f06..47eac27 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/ChangeEmailTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/ChangeEmailTest.java
@@ -25,7 +25,8 @@ "testing\\.com", "tester@testing\\.com", ".*google\\.com", - "tester@gerrit\\..*" + "tester@gerrit\\..*", + "(?!some_).*@someinc\\.com", }; @Test @@ -34,6 +35,10 @@ assertThat(ChangeEmailValidator.match("tester@testing.com", emailPatterns)).isTrue(); assertThat(ChangeEmailValidator.match("tester@google.com", emailPatterns)).isTrue(); assertThat(ChangeEmailValidator.match("tester@gerrit.net", emailPatterns)).isTrue(); + assertThat(ChangeEmailValidator.match("user@someinc.com", emailPatterns)).isTrue(); + assertThat(ChangeEmailValidator.match("some_user@someinc.com", emailPatterns)).isFalse(); + assertThat(ChangeEmailValidator.match("some_user@something_different.com", emailPatterns)) + .isFalse(); } @Test