commit 5766c39fa7dc8602bc104991bf25e292d5564b8e
author Adithya Chakilam <achakila@codeaurora.org> Tue Feb 15 18:14:07 2022 -0500
committer Martin Fick <martin.fick@linaro.org> Wed Sep 07 14:35:33 2022 -0600
tree 1eb45069a939139597782162bb5eea7cdedbfc39
parent 83c5be4c2486e4b6d83ef7d693968204f854a482

Suppress ReturnValueIgnored warnings

This supresses the warning on hasNext() call inside the
next() of TaskExpression. The hasNext() call is done to
avoid calling next() without first calling the hasNext()
and has no effect when called repeatedly.

Change-Id: I6a317902b9f9e91f3dfbd9e6cc1ad7b5c57eee80

src/main/java/com/googlesource/gerrit/plugins/task/TaskExpression.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/task/TaskExpression.java b/src/main/java/com/googlesource/gerrit/plugins/task/TaskExpression.java
index 90dffff..b3fc530 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/task/TaskExpression.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/task/TaskExpression.java
@@ -66,7 +66,8 @@
 
       @Override
       public String next() {
-        hasNext(); // in case next() was (re)called w/o calling hasNext()
+        // Can't use @SuppressWarnings("ReturnValueIgnored") on method call
+        boolean ignored = hasNext(); // in case next() was (re)called w/o calling hasNext()
         if (!hasNext) {
           throw new NoSuchElementException("No more names, yet expression was not optional");
         }