| commit | 3ffb17385ab6210dc950f03a668379fc27878065 | [log] [tgz] |
|---|---|---|
| author | Ivan Frade <ifrade@google.com> | Fri Mar 19 12:06:23 2021 -0700 |
| committer | Ivan Frade <ifrade@google.com> | Tue Mar 30 08:59:03 2021 -0700 |
| tree | 48dcada20b820e1d2289ae6d53b67025cfceeb8a | |
| parent | 2da90e2524c4607cd75a6adb83a2d763f96f6185 [diff] |
Simplify the URI/repoName handling The methods in the GerritRemoteReader can receive URIs or repoNames (a host-relative name of the project). The handling of the URIs is inconsistent: sha1() takes the path before calling openRepository() while readFileWithMode() passes through the whole URL. This is wrong e.g. for external URLs. An outter host URL can open the wrong repo in sha1() and nothing in readFileWithMode(). Make internal methods to open by URI or name. The public methods must decide what to invoke. This makes clear what is coming and gives a unique place for the URI -> repoName translation. This also paves the way to plug a repository opener that supports cross-host URLs. Change-Id: Ia2a925764bb9c3305a434240d44873b31c6e0c75
The plugin will update a superproject to contain the submodules defined in the manifest XML file whenever the manifest repo is changed.
For more information see the documentation or the build instructions